<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3547/">https://reviewboard.asterisk.org/r/3547/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3547/diff/2/?file=58626#file58626line293" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/cel/cel_pgsql.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void pgsql_log(struct ast_event *event)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">293</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">ast_debug</span><span class="p">(</span><span class="mi">2</span><span class="p">,</span> <span class="s">"<span class="hl">i</span>nserting a CEL record.</span><span class="se">\n</span><span class="s">"</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">292</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">ast_debug</span><span class="p">(</span><span class="mi">2</span><span class="p">,</span> <span class="s">"<span class="hl">I</span>nserting a CEL record<span class="hl">: [%s]</span>.</span><span class="se">\n</span><span class="s">"</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">ast_str_buffer</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">sql</span></span><span class="p"><span class="hl">)</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All the other "Inserting/Executing" (of CDRs) above are level 3.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't look through all changes well enough to give it a ship-it.
But you didn't remove any logging that I like to see, so that's good :)</pre>
<p>- wdoekes</p>
<br />
<p>On May 18th, 2014, 8 p.m. UTC, Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated May 18, 2014, 8 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch addresses some aesthetic issues in Asterisk. These are all just minor tweaks to improve the look of the CLI when used in a variety of settings. Specifically:
* A number of chatty verbose messages were removed or demoted to DEBUG messages. Verbose messages with a verbosity level of 5 or higher were - if kept as verbose messages - demoted to level 4. Several messages that were emitted at verbose level 3 were demoted to 4, as announcement of dialplan applications being executed occur at level 3 (and so the effects of those applications should generally be less).
* Some verbose messages that only appear when their respective 'debug' options are enabled were bumped up to always be displayed.
* Prefix/timestamping of verbose messages were moved to the verboser handlers. This was done to prevent duplication of prefixes when the timestamp option (-T) is used with the CLI.
* Verbose magic is removed from messages before being emitted to non-verboser handlers. This prevents the magic in multi-line verbose messages (such as SIP debug traces or the output of DumpChan) from being written to files.
* _Slightly_ better support for the "light background" option (-W) was added. This includes using ast_term_quit in the output of XML documentation help, as well as changing the "Asterisk Ready" prompt to bright green on the default background (which stands a better chance of being displayed properly than bright white).
Overall, the output of starting Asterisk with the timestamp option is usable, the colours are a bit more consistent, and the messages displayed when starting Asterisk - with or without verbosity - is cleaner.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_odbc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/res_jabber.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/res_fax.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/res_config_pgsql.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/res_config_odbc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/res_config_curl.c <span style="color: grey">(414121)</span></li>
<li>/trunk/res/parking/parking_applications.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/xmldoc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/optional_api.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/logger.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/loader.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/config_options.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/bridge.c <span style="color: grey">(414121)</span></li>
<li>/trunk/main/asterisk.c <span style="color: grey">(414121)</span></li>
<li>/trunk/include/asterisk/logger.h <span style="color: grey">(414121)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cel/cel_pgsql.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cel/cel_odbc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cdr/cdr_sqlite3_custom.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cdr/cdr_pgsql.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cdr/cdr_odbc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/cdr/cdr_adaptive_odbc.c <span style="color: grey">(414121)</span></li>
<li>/trunk/bridges/bridge_builtin_features.c <span style="color: grey">(414121)</span></li>
<li>/trunk/apps/app_waitforsilence.c <span style="color: grey">(414121)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(414121)</span></li>
<li>/trunk/apps/app_mixmonitor.c <span style="color: grey">(414121)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3547/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>