<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3540/">https://reviewboard.asterisk.org/r/3540/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks simple and straightforward to me.</pre>
<br />
<p>- Jared Smith</p>
<br />
<p>On May 14th, 2014, 3:19 p.m. UTC, wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated May 14, 2014, 3:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When dialing SIP/account_a + SIP/account_b, and account_b picks up, chan_sip sends
out a Reason header with SIP;cause=200;text="Call completed elsewhere", signifying
that the call was picked up.
The SIP phone then does not show "1 missed call".
However, then dialing Local/account_a + Local/account_b, this does not work.
This review addresses that.
When hanging up obsolete channels in chan_local, the answered_elsewhere flag is
propagated to cancelled (parent) channel using the hangupcause.
In app_dial, this hangupcause is checked and passed down to the other calls to be
cancelled.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dialplan:
[default]
exten => 201,1,Dial(SIP/account_b&SIP/account_c,5)
exten => 202,1,Dial(Local/b@dial&Local/c@dial,5)
;; also tested with /n for no-local-channel-optimization, behaves the same as without
[dial]
exten => b,1,Dial(SIP/account_b)
exten => c,1,Dial(SIP/account_c)
sip.conf held 3 accounts: account_a, account_b and account_c.
Before patch:
201 202 <-- account_a calls these
+---------------+---------------+
timeout | 1 missed call | 1 missed call |
+---------------+---------------+
account_b | | 1 missed call | <-- account_c sees these
picks up +---------------+---------------+
After patch:
201 202 <-- account_a calls these
+---------------+---------------+
timeout | 1 missed call | 1 missed call |
+---------------+---------------+
account_b | | | <-- account_c sees these
picks up +---------------+---------------+
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/channels/chan_local.c <span style="color: grey">(413892)</span></li>
<li>/branches/1.8/apps/app_dial.c <span style="color: grey">(413892)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3540/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>