<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3515/">https://reviewboard.asterisk.org/r/3515/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 1st, 2014, 7:27 p.m. UTC, <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3515/diff/1/?file=58167#file58167line318" style="color: black; font-weight: bold; text-decoration: underline;">/team/group/media_formats-reviewed/channels/chan_pjsip.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int chan_pjsip_set_rtp_peer(struct ast_channel *chan,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">317</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">ast_format_cap_<span class="hl">copy</span></span><span class="p">(</span><span class="n">session</span><span class="o">-></span><span class="n">direct_media_cap</span><span class="p">,</span> <span class="n"><span class="hl">cap</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">318</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">ast_format_cap_<span class="hl">remove_bytype</span></span><span class="p">(</span><span class="n">session</span><span class="o">-></span><span class="n">direct_media_cap</span><span class="p">,</span> <span class="n"><span class="hl">AST_MEDIA_TYPE_UNKNOWN</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">319</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">ast_format_cap_append_by_type</span><span class="p">(</span><span class="n">session</span><span class="o">-></span><span class="n">direct_media_cap</span><span class="p">,</span> <span class="n">cap</span><span class="p">,</span> <span class="n">AST_MEDIA_TYPE_UNKNOWN</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry I hadn't noticed this before, but I think these two lines right next to each other highlight a naming consistency issue in the API (bytype vs. by_type). I suggest that somewhere outside this review, you make a change so that one or the other is followed and you don't have this weird mix.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've created issue ASTERISK-23715 to track this (specifically reviewing the API for stuff such as this).</pre>
<br />
<p>- Joshua</p>
<br />
<p>On April 30th, 2014, 10:49 p.m. UTC, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated April 30, 2014, 10:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change moves chan_pjsip and the other PJSIP modules over to the new media formats work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/group/media_formats-reviewed/res/res_pjsip_session.c <span style="color: grey">(413144)</span></li>
<li>/team/group/media_formats-reviewed/res/res_pjsip_sdp_rtp.c <span style="color: grey">(413144)</span></li>
<li>/team/group/media_formats-reviewed/res/res_pjsip/pjsip_configuration.c <span style="color: grey">(413144)</span></li>
<li>/team/group/media_formats-reviewed/include/asterisk/res_pjsip_session.h <span style="color: grey">(413144)</span></li>
<li>/team/group/media_formats-reviewed/include/asterisk/res_pjsip.h <span style="color: grey">(413144)</span></li>
<li>/team/group/media_formats-reviewed/include/asterisk/format_cache.h <span style="color: grey">(413144)</span></li>
<li>/team/group/media_formats-reviewed/channels/pjsip/dialplan_functions.c <span style="color: grey">(413144)</span></li>
<li>/team/group/media_formats-reviewed/channels/chan_pjsip.c <span style="color: grey">(413144)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3515/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>