<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3444/">https://reviewboard.asterisk.org/r/3444/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are the [general] and [globals] contexts necessary in your dialplan since they have no extensions under them?</pre>
<br />
<p>- Benjamin Keith Ford</p>
<br />
<p>On April 17th, 2014, 4:10 p.m. UTC, Scott Emidy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Scott Emidy.</div>
<p style="color: grey;"><i>Updated April 17, 2014, 4:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23447">ASTERISK-23447</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These three tests involve using PJSIP in order to execute callee initiated blind transfers.
Also all three of these tests fail due to the unresolved issues ASTERISK-23501 and ASTERISK-23502.
These tests required a few aspects in each test such as the SIPREFERTOHDR, SIPREFERREDBYHDR, SIPTRANSFER, SIPREFERRINGCONTEXT, BLINDTRANSFER Event, TRANSFER_CONTEXT that comes into play in the second iterations, and Referred-By header. MusicOnHOldStart and MusicOnHoldStop were only required for the callee_hold test.
The three tests were:
1) Callee initiated transfer with direct media (callee_direct_media) - This consists of direct media being initiated between the endpoints before and after the transfer.
2) Callee initiated transfer with hold (callee_hold) - This consists of a blind transfer that puts the caller on hold before they are transferred.
3) Callee initiated transfer with REFER only (callee_only_refer) - This consists of no hold or media just a basic REFER. Also John Bigelow made changes to the pjsua_mod.py to be able to associate pjsua accounts with a specific pjsua transport.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>./asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/transfer.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/sipp/charlie.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/sipp/alice.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/charlie.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/alice.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: grey">(4957)</span></li>
<li>./asterisk/trunk/lib/python/asterisk/pjsua_mod.py <span style="color: grey">(4957)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3444/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>