<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3420/">https://reviewboard.asterisk.org/r/3420/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Scott Emidy.</div>
<p style="color: grey;"><i>Updated April 23, 2014, 11:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Completely redid the test so that it now involves a call_files_retries.py module that holds the userevents for the tests.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23218">ASTERISK-23218</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These tests involved checking that call files max retries are functioning as planned through four tests:
1) The first test (call_file_retries_fail) required that the call file originates a local channel to a dialplan extension that will always fail, and checks to make sure that it ran through all of its max retries.
2) The second test (call_file_retries_success) involves a call file that originates a local channel that will fail once, but then is answered before it hits its max retries.
3) The third test (call_file_retries_alwaysdelete) consists of checking whether or not the call file was deleted from the [astspooldir]'s outgoing folder when the alwaysdelete option is set to 'no'.
4) The fourth and final test (call_file_retries_archive) consists of checking whether or not the call file was placed in [astspooldir]'s outgoing_done folder when archive is set to 'yes'.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>./asterisk/trunk/tests/pbx/tests.yaml <span style="color: grey">(4935)</span></li>
<li>./asterisk/trunk/tests/pbx/call_file_retries_success/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/pbx/call_file_retries_success/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/pbx/call_file_retries_fail/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/pbx/call_file_retries_fail/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/pbx/call_file_retries_archive/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/pbx/call_file_retries_archive/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/lib/python/asterisk/pluggable_modules.py <span style="color: grey">(4935)</span></li>
<li>./asterisk/trunk/lib/python/asterisk/call_file_retries.py <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3420/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>