<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3443/">https://reviewboard.asterisk.org/r/3443/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks like these patches were merely attached to the review board posting, as opposed to being uploaded using post-review or uploaded directly as a diff. That makes it very hard to review.
Please review the instructions for using Review Board (https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage) and post the diffs so that they show up as code to be reviewed.</pre>
<br />
<p>- Matt Jordan</p>
<br />
<p>On April 14th, 2014, 12:34 a.m. CDT, Kevin McCoy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Kevin McCoy.</div>
<p style="color: grey;"><i>Updated April 14, 2014, 12:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="None">https://issues.asterisk.org/jira/browse/ASTERISK-23324</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Japanese language support patch for sound files in app_voicemail.c and say.c, depends on entire sound file package currently available in release candidate format as per https://issues.asterisk.org/jira/browse/ASTERISK-23324
https://www.dropbox.com/s/axu6gfnf9fh40hz/asterisk-core-sounds-ja-wav-and-patch.tgz
Word order and plurals, dates, counts in Japanese are all significantly different than English, hence the need for this patch. Tested working with Asterisk 12.
Here is the installation procedure from the README contained in the RC archive:
----------
Install Asterisk Sound Files:
mkdir /var/lib/asterisk/sounds/ja
cd /var/lib/asterisk/sounds/ja
wget http://downloads.asterisk.org/pub/telephony/sounds/asterisk-core-sounds-ja-gsm-current.tar.gz
tar xvfz asterisk-core-sounds-ja-gsm-current.tar.gz
rm -f asterisk-core-sounds-ja-gsm-current.tar.gz
chown -R asterisk.asterisk /var/lib/asterisk/sounds/ja
How To Change Default SIP Channel Language to Japanese
Using Asterisk (vanilla):
vi /etc/asterisk/sip.conf
Edit language variable to:
language = ja
Using FreePBX:
On the FreePBX menu -> Settings -> Asterisk SIP Settings -> Advanced General Settings section -> Language field
Set Language field to : ja
Install Japanese Patch:
Download Asterisk 12 source
Change directory to Asterisk 12 source folder
Download the patches for say.c and app_voicemail.c
patch -p0 < say.c.20140226.jp.patch
patch -p0 < app_voicemail.c.20140226.jp.patch
Compile Asterisk 12 source as usual
------
I'm happy to answer questions about the code.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3443/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://reviewboard.asterisk.org/media/uploaded/files/2014/04/14/cfe35d8c-066d-4b69-9f52-8e104f8b3770__app_voicemail.c.20140226.jp.patch">app_voicemail.c.20140226.jp.patch</a></li>
<li><a href="https://reviewboard.asterisk.org/media/uploaded/files/2014/04/14/2f6dd68b-7549-48d8-8750-e043202f41f5__say.c.20140226.jp.patch">say.c.20140226.jp.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>