<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3450/">https://reviewboard.asterisk.org/r/3450/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 15th, 2014, 4:45 p.m. CDT, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I know I was thinking that this would be necessary everywhere; it may still be.
However, when I wrote that particular bug report, we were still having crashes with reference counting issues in the main Stasis application loop. Your previous commits fixed that.
While I dislike our current mechanism of tracking the bridge, I also don't want to make the reference counting issue more confusing than it already is. Is this patch still necessary? Do we feel that there are situations when a control structure has a pointer to a bridge but the bridge has been disposed of by some one else?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All usages other than the one that is already fixed are a check to see whether the control is associated with any bridge or specific bridge and do not pose a stale pointer risk.
The only risk is new consumers of stasis_app_get_bridge and in this case, I would be satisfied with a header documentation change since the scope is fairly small.</pre>
<br />
<p>- opticron</p>
<br />
<p>On April 15th, 2014, 4:09 p.m. CDT, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated April 15, 2014, 4:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23588">ASTERISK-23588</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch ensures that the Stasis control structure holds a reference to the bridge the channel is in so that the pointer does not become stale. This also introduces a new function for use cases that only need to check that the channel is in a bridge and have no need for the bridge itself since stasis_app_get_bridge now bumps the bridge's refcount when returning it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/12/res/stasis/control.c <span style="color: grey">(412426)</span></li>
<li>branches/12/res/res_stasis_recording.c <span style="color: grey">(412426)</span></li>
<li>branches/12/res/res_stasis.c <span style="color: grey">(412426)</span></li>
<li>branches/12/res/ari/resource_bridges.c <span style="color: grey">(412426)</span></li>
<li>branches/12/include/asterisk/stasis_app.h <span style="color: grey">(412426)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3450/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>