<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3363/">https://reviewboard.asterisk.org/r/3363/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3363/diff/1/?file=56114#file56114line489" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/lib/python/asterisk/realtime_test_module.py</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">489</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">reactor</span><span class="o">.</span><span class="n">listenTCP</span><span class="p">(</span><span class="mi">8000</span><span class="p">,</span> <span class="n">factory</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port 8000 is commonly used as the alternate/unprivileged port 80, so this increases the chance of port conflicts. I often use 127.0.0.1:8000 for SSH tunnels to remote HTTP from my desktop (test system). I believe the correct fix would be for realtime_test_module to listen to a dynamic port (port 0), generate extconfig.conf from the result. I recognize that doing so is probably out of scope for this change. Using a higher port or a different localhost IP would reduce the chance of this happening.
As a workaround can this test detect if the HTTP server fails to start due to port already in use and skip/abort the test? We would want to avoid hitting an unknown daemon listening to port 127.0.0.1:8000, especially since that daemon might trust our requests due to localhost source address.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3363/diff/1/?file=56118#file56118line15" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/tests/realtime/destroy/test-config.yaml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">15</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p-Indicator">-</span> <span class="l-Scalar-Plain">asterisk</span><span class="p-Indicator">:</span> <span class="s">'res_mwi_external_ami'</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please add res_config_curl to all tests. I have not checked other dependencies, but libcurl is an external dependency so this is an important one to check.</pre>
</div>
<br />
<p>- Corey Farrell</p>
<br />
<p>On March 15th, 2014, 2:34 p.m. EDT, Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated March 15, 2014, 2:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This introduces a new pluggable module to the Asterisk testsuite intended to assist in testing using realtime storage. The test module sets up an HTTP server on port 8000 and services requests Asterisk makes using its res_config_curl realtime backend. The actual data is stored in memory in python using simple dictionaries and lists. The test module configuration allows for data to be preloaded into python before Asterisk is started so that Asterisk may retrieve realtime data during startup. Once AMI is connected to Asterisk, the realtime test module hands over control to a python module so that the test may be further controlled by the test writer.
Along with the module are six realtime tests, each designed to test an operation that Asterisk can attempt. The "require" operation is not tested since we currently always claim to have the proper items stored in the expected way.
There are potential improvements that could be made, such as:
* Memoization of HTTP resources served by the test module.
* yaml-driven test development beyond the initial population of realtime data.
* Potentially allow for the realtime test module to be run stand-alone so that developers can have an easy realtime store to use for testing.
None of these are enough to prevent inclusion into the test suite though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/tests.yaml <span style="color: grey">(4836)</span></li>
<li>/asterisk/trunk/tests/realtime/update/update.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/update/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/update/configs/ast1/sorcery.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/update/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/store/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/store/store.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/store/configs/ast1/sorcery.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/store/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/static/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/static/static.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/static/configs/ast1/modules.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/static/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/single/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/single/single.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/single/configs/ast1/sorcery.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/single/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/multi/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/multi/multi.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/multi/configs/ast1/sorcery.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/multi/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/destroy/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/destroy/destroy.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/destroy/configs/ast1/sorcery.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/realtime/destroy/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/realtime_test_module.py <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3363/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>