<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3320/">https://reviewboard.asterisk.org/r/3320/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A couple of nits that may not need to even be changed.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3320/diff/2/?file=56259#file56259line199" style="color: black; font-weight: bold; text-decoration: underline;">/team/group/media_formats-reviewed/formats/format_pcm.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static off_t pcm_tell(struct ast_filestream *fs)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">198</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="k">if</span> <span class="p">(</span><span class="n">s</span><span class="o">-></span><span class="n">fmt</span><span class="o">-></span><span class="n">format</span> <span class="o">==</span> <span class="n"><span class="hl">AST_FORMAT_ALAW</span></span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">187</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="k">if</span> <span class="p">(</span><span class="n">s</span><span class="o">-></span><span class="n">fmt</span><span class="o">-></span><span class="n">format</span> <span class="o">==</span> <span class="n"><span class="hl">ast_format_alaw</span></span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe use ast_format_cmp here to be consistent with the other changes and if ast_format_cmp ever change this will be picked up.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3320/diff/2/?file=56259#file56259line403" style="color: black; font-weight: bold; text-decoration: underline;">/team/group/media_formats-reviewed/formats/format_pcm.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int au_rewrite(struct ast_filestream *s, const char *comment)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">402</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="k">if</span> <span class="p">(</span><span class="n">fs</span><span class="o">-></span><span class="n">fmt</span><span class="o">-></span><span class="n">format</span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">id</span></span> <span class="o">==</span> <span class="n"><span class="hl">AST_FORMAT_G</span>722</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">391</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="k">if</span> <span class="p">(</span><span class="n">fs</span><span class="o">-></span><span class="n">fmt</span><span class="o">-></span><span class="n">format</span> <span class="o">==</span> <span class="n"><span class="hl">ast_format_g</span>722</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Another spot to use ast_format_cmp.</pre>
</div>
<br />
<p>- Kevin Harwell</p>
<br />
<p>On March 20th, 2014, 6:39 a.m. CDT, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated March 20, 2014, 6:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change moves format modules over to the new media formats API. Some duplicated code was removed as it will be consolidated in the core.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/group/media_formats-reviewed/formats/format_wav_gsm.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_wav.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_vox.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_sln.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_siren7.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_siren14.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_pcm.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_ogg_vorbis.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_jpeg.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_ilbc.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_h264.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_h263.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_gsm.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_g729.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_g726.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_g723.c <span style="color: grey">(409286)</span></li>
<li>/team/group/media_formats-reviewed/formats/format_g719.c <span style="color: grey">(409286)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3320/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>