<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3398/">https://reviewboard.asterisk.org/r/3398/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think this is the correct way to fix the problem. This works around what appears to be a valid problem.
If an application creates a bridge, it should receive the BridgeDestroyed events. It should not have to explicitly subscribe to the thing that it just created. Down that path lies all sorts of madness: do I have to subscribe to a channel if I create it? Yuck.
Unless I'm really misreading what is occurring here, this appears to be a bug in Asterisk, and should be fixed there.</pre>
<br />
<p>- Matt Jordan</p>
<br />
<p>On March 26th, 2014, 8 a.m. CDT, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 8 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes the two tests affected by the fix (r411086) to the bridge subscription leak. They were depending on the leaked subscription to catch bridge destruction events instead of holding an explicit subscription for that purpose. They now explicitly subscribe to and unsubscribe from the bridge at creation and destruction as necessary.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Made sure the tests got the events they were expecting.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/rest_api/bridges/delete/bridge_delete.py <span style="color: grey">(4885)</span></li>
<li>asterisk/trunk/tests/rest_api/bridges/bridge_by_id/test-config.yaml <span style="color: grey">(4885)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3398/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>