<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3392/">https://reviewboard.asterisk.org/r/3392/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only thing I found was a minor nitpick. Otherwise, it looks good to me.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3392/diff/1/?file=56469#file56469line23" style="color: black; font-weight: bold; text-decoration: underline;">./asterisk/trunk/tests/channels/pjsip/headers/test-config.yaml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p-Indicator">-</span> <span class="p-Indicator">{</span> <span class="s">'key-args'</span><span class="p-Indicator">:</span> <span class="p-Indicator">{</span><span class="s">'scenario'</span><span class="p-Indicator">:</span> <span class="s">'outbound-headers.xml'</span><span class="p-Indicator">,</span> <span class="s">'-i'</span><span class="p-Indicator">:</span> <span class="s">'127.0.0.1'</span><span class="p-Indicator">,</span> <span class="s">'-p'</span><span class="p-Indicator">:</span> <span class="s">'5062'</span><span class="p-Indicator">,</span> <span class="s">'-d'</span><span class="p-Indicator">:</span> <span class="s">'3000'</span><span class="p-Indicator">}</span> <span class="p-Indicator">}</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1"># Outbound-recv-headers receives the call</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p-Indicator">-</span> <span class="p-Indicator">{</span> <span class="s">'key-args'</span><span class="p-Indicator">:</span> <span class="p-Indicator">{</span><span class="s">'scenario'</span><span class="p-Indicator">:</span> <span class="s">'outbound-recv-headers.xml'</span><span class="p-Indicator">,</span> <span class="s">'-i'</span><span class="p-Indicator">:</span> <span class="s">'127.0.0.1'</span><span class="p-Indicator">,</span> <span class="s">'-p'</span><span class="p-Indicator">:</span> <span class="s">'5063'</span><span class="p-Indicator">,</span> <span class="s">'-d'</span><span class="p-Indicator">:</span> <span class="s">'3000'</span><span class="p-Indicator">}</span> <span class="p-Indicator">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These two scenarios don't need '-d': '3000' since they do not have any <pause /> elements in them.</pre>
</div>
<br />
<p>- Mark Michelson</p>
<br />
<p>On March 25th, 2014, 3:27 p.m. UTC, Benjamin Keith Ford wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Benjamin Keith Ford.</div>
<p style="color: grey;"><i>Updated March 25, 2014, 3:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23453">ASTERISK-23453</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test covers two different scenarios: reading the headers on an inbound call, and reading/modifying the headers on an outbound call.
- On the inbound call, a standard header is read, as well as a custom header.
- On the outbound call, a standard header is read, as well as a custom header. Custom headers are added to the SIP packet, modified, and removed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>./asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: grey">(4836)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/headers/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/headers/sipp/outbound-recv-headers.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/headers/sipp/outbound-headers.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/headers/sipp/inbound-headers.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/headers/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./asterisk/trunk/tests/channels/pjsip/headers/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3392/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>