<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3368/">https://reviewboard.asterisk.org/r/3368/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree that this is workaround more than it is the "correct" fix to be applying, but after going through the scenarios in my head, this looks like a good way to get around the problem.</pre>
<br />
<p>- Mark Michelson</p>
<br />
<p>On March 17th, 2014, 2:21 p.m. UTC, one47 wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By one47.</div>
<p style="color: grey;"><i>Updated March 17, 2014, 2:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22079">ASTERISK-22079</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As requested, here is a workaround (not a fix) for the SIP SEGV caused by a scheduler race condition.
If a provisional keepalive is simultaneously rescheduled/cancelled, and executed by 2 parallel threads, then a scheduled event can be leaked.
The correct fix will probably involve a re-factoring of the scheduler so that a scheduled-job-reference is held by the owner, rather than just a scheduled-job-id as at present. That is outside the scope of this fix, which simply re-checks that the scheduler-id is unchanged after the lock has been obtained when running the scheduled job.
There is probably scope for doing this is several other scheduled function calls.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Run on live server for several weeks.
Tested on load-test environment with following dialplan, which previously caused a crash in < 30 mins at 1 call per second.
exten => 900,1,NoOp(Crash Generator)
same => n,Ringing
same => n,Wait(60)
same => n,Progress
same => n,Hangup</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/tags/1.8.25.0/channels/chan_sip.c <span style="color: grey">(408955)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3368/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>