<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3319/">https://reviewboard.asterisk.org/r/3319/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3319/diff/2/?file=56267#file56267line180" style="color: black; font-weight: bold; text-decoration: underline;">/team/group/media_formats-reviewed/include/asterisk/codec.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">const char *ast_codec_media_type2str(enum ast_media_type type);</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">180</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">unsigned</span> <span class="kt">int</span> <span class="nf">ast_codec_determine_length</span><span class="p">(</span><span class="k">const</span> <span class="k">struct</span> <span class="n">ast_codec</span> <span class="o">*</span><span class="n">codec</span><span class="p">,</span> <span class="kt">unsigned</span> <span class="kt">int</span> <span class="n">samples</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kind of a nitpick, but for this and ast_format_determine_length(), the word "determine" is out of place. Just a simple "get" works better.</pre>
</div>
<br />
<p>- Mark Michelson</p>
<br />
<p>On March 20th, 2014, 11:40 a.m. UTC, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated March 20, 2014, 11:40 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Through implementing things some additional functionality needed to be added/tweaked. This does so.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/group/media_formats-reviewed/main/format_cap.c <span style="color: grey">(410188)</span></li>
<li>/team/group/media_formats-reviewed/main/format.c <span style="color: grey">(410186)</span></li>
<li>/team/group/media_formats-reviewed/main/codec.c <span style="color: grey">(410188)</span></li>
<li>/team/group/media_formats-reviewed/include/asterisk/frame.h <span style="color: grey">(410188)</span></li>
<li>/team/group/media_formats-reviewed/include/asterisk/format_cap.h <span style="color: grey">(410188)</span></li>
<li>/team/group/media_formats-reviewed/include/asterisk/format_cache.h <span style="color: grey">(410189)</span></li>
<li>/team/group/media_formats-reviewed/include/asterisk/format.h <span style="color: grey">(410186)</span></li>
<li>/team/group/media_formats-reviewed/include/asterisk/codec.h <span style="color: grey">(410188)</span></li>
<li>/team/group/media_formats-reviewed/include/asterisk/callerid.h <span style="color: grey">(409286)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3319/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>