<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3371/">https://reviewboard.asterisk.org/r/3371/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated March 18, 2014, 5:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Made ast_unreal_new_channels() generate the ;2 uniqueid on a stack variable instead of mallocing it.
* Fixed minor hole in generating the ;2 uniqueid string length.
* Created public and internal lengths of uniqueid. The internal length can handle a max public uniqueid plus an appended ;2.
* Made ast_channel_internal_set_fake_ids() use the safer ast_copy_string().</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Miscellaneous uniqueid cleanups and fixes.
* Fix memory leak in ast_unreal_new_channels().
* Made send error response in ARI and AMI instead of just logging excessive uniqueid length. action_originate() and ari_channels_handle_originate_with_id().
* free() and ast_free() are NULL tolerant so they don't need a NULL test before calling.
* Made use better struct initialization format instead of position dependent initialization format. Also anything not explicitly initialized in the struct is initialized to zero by the compiler.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiler blessed and code inspection.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/res_stasis_snoop.c <span style="color: grey">(410875)</span></li>
<li>/branches/12/res/ari/resource_channels.c <span style="color: grey">(410875)</span></li>
<li>/branches/12/main/manager.c <span style="color: grey">(410875)</span></li>
<li>/branches/12/main/dial.c <span style="color: grey">(410875)</span></li>
<li>/branches/12/main/core_unreal.c <span style="color: grey">(410875)</span></li>
<li>/branches/12/main/channel_internal_api.c <span style="color: grey">(410875)</span></li>
<li>/branches/12/include/asterisk/rtp_engine.h <span style="color: grey">(410875)</span></li>
<li>/branches/12/include/asterisk/channel.h <span style="color: grey">(410875)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3371/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>