<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3365/">https://reviewboard.asterisk.org/r/3365/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any chance adding a warning header explaining why we are 488ing? According to http://tools.ietf.org/html/rfc6337#section-2.3 it's preferred, but I'm unsure if pjproject exposes the ability.</pre>
<br />
<p>- Paul Belanger</p>
<br />
<p>On March 16th, 2014, 8:36 p.m. UTC, Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Joshua Colp.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated March 16, 2014, 8:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In a perfect world, an Asterisk channel would care very little (if at all) about the media streams that happened to be related to it. It would merrily exist as a path of communication between some endpoint and Asterisk, and the data (which may or may not be media at all!) that flowed (like a stream!) between the endpoint and Asterisk would be a completely separate concept. Alas, such is not the world we exist in. Asterisk *needs* audio. As frames. At a nice periodic rate, please. Strange things happen when it doesn't get it.
Today, the res_pjsip stack will do some funky things if you give it an offer with no media. There will be a slew of warnings, some compatibility errors, strange transcoding attempts, and finally you may get an Answer to the Offer that contains an audio codec in a video media stream (probably ulaw) - just because Asterisk *really* wants audio. (Can you please send some with this video?)
This is clearly not right. This patch makes it so that res_pjsip_session looks to see if we have an audio stream (in validate_sdp) and, if not, it declines the offer.
I offer this patch in the hopes that it will some day be removed...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests are ongoing. A test has been written that offers only a single video stream. Prior to this patch; hilarity. With this patch, Asterisk rejects the offer with a 488.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/res_pjsip_session.c <span style="color: grey">(410554)</span></li>
<li>/branches/12/res/res_pjsip_sdp_rtp.c <span style="color: grey">(410554)</span></li>
<li>/branches/12/include/asterisk/res_pjsip_session.h <span style="color: grey">(410554)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3365/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>