<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3288/">https://reviewboard.asterisk.org/r/3288/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is good to go other than the minor nitpicks below.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3288/diff/2/?file=55660#file55660line89" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/sipp/subscribe.xml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><Reference</span> <span class="na">variables=</span><span class="s">"substate"</span> <span class="nt">/></span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">90</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><Reference</span> <span class="na">variables=</span><span class="s">"resubstate"</span> <span class="nt">/></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These can be combined into:
<Reference variables="substate,resubstate" /></pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3288/diff/2/?file=55667#file55667line13" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/unsubscribe.py</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kn">from</span> <span class="nn">twisted.internet</span> <span class="kn">import</span> <span class="n">reactor</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This import is unnecessary.</pre>
</div>
<br />
<p>- opticron</p>
<br />
<p>On March 7th, 2014, 8:45 a.m. CST, jbigelow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By jbigelow.</div>
<p style="color: grey;"><i>Updated March 7, 2014, 8:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23344">ASTERISK-23344</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These tests cover re-subscribe and un-subscribe for presence using PJSIP.
Note: This review request also re-organizes existing subscription tests.
Tests:
* unsubscribe - Nominal test using the pjsua pluggable module where "alice" subscribes to "bob. Alice then un-subscribes (expiration of '0') and the pass result is set based upon the subscription state being reported as terminated. Otherwise the fail result is set.
* resubscribe - Nominal test that uses SIPp (aka. "alice") to subscribe to "bob" with an expiration of 300. Upon successfully subscribing, alice then subscribes to bob again but with an expiration of 600. This ensures the re-subscribe is successful per receiving a 200 response and a Notify with the expected expiration in the Subscription-State header.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Ensured tests pass on multiple executions
* Ensured the testsuite & Asterisk logs looked good.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/unsubscribe.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/configs/ast1/modules.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/sipp/subscribe.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/configs/ast1/modules.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscribe/tests.yaml <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/test-config.yaml <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/sipp/subscribe.xml <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/run-test <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/configs/ast1/pjsip.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/configs/ast1/modules.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/test-config.yaml <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/sipp/subscribe.xml <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/run-test <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/configs/ast1/pjsip.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/configs/ast1/extensions.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_xpidf/test-config.yaml <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_xpidf/state_check.py <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/pjsip.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/modules.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/extensions.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_pidf/test-config.yaml <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_pidf/state_check.py <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/pjsip.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/modules.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/extensions.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi_aggregate/test-config.yaml <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi_aggregate/mwi_check.py <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi_aggregate/configs/ast1/pjsip.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi_aggregate/configs/ast1/modules.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi/test-config.yaml <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi/mwi_check.py <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/pjsip.conf <span style="color: grey">(4799)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/modules.conf <span style="color: grey">(4799)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3288/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>