<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3306/">https://reviewboard.asterisk.org/r/3306/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 5th, 2014, 7:34 p.m. CST, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So this completely solves the problem in the report, and we may decide this is sufficient.
In general, however, this problem happens a lot - someone starts MoH on a channel, hangs it up, does something else with it... and we don't really ever stop MoH. We just kill the channel.
Would it be worthwhile to see if MoH was started on a channel, and stop it during ast_hangup?</pre>
</blockquote>
<p>On March 5th, 2014, 9:38 p.m. CST, <b>rmudgett</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well we could do it on an ast_hangup() or before the h-exten/hangup_handlers run but if the channel is hungup then MOH has to have been stopped. Adding it there would just increase the AMI traffic.
The verbose MOH stop message is generated whenever the MOH class is released and truly stops the MOH stream. This is not the same as intentionally stopping MOH. You can get two MOH start messages without a stop if a recording is played when MOH is running and MOH is then resumed. It is a bit of a mess when the MOH start/stop messages are sent. res_musiconhold always knows when MOH starts/stops being streamed.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should we just move the messages to res_musiconhold, and let it be the arbiter of the messages? That would make more sense than having it sprinkled all over the codebase.</pre>
<br />
<p>- Matt</p>
<br />
<p>On March 5th, 2014, 6:56 p.m. CST, rmudgett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated March 5, 2014, 6:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23311">ASTERISK-23311</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When MOH is playing to a user in a conference and the user is kicked or hangs up from the conference then the AMI MusicOnHoldSotp events didn't happen.
This patch should be done for v11+.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before patch the AMI MusicOnHoldStop event did not happen when the user is kicked or hangs up to leave the conference.
With the patch the event happens.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/apps/confbridge/conf_state_single_marked.c <span style="color: grey">(409977)</span></li>
<li>/branches/12/apps/confbridge/conf_state_single.c <span style="color: grey">(409977)</span></li>
<li>/branches/12/apps/confbridge/conf_state_inactive.c <span style="color: grey">(409977)</span></li>
<li>/branches/12/apps/confbridge/conf_state.c <span style="color: grey">(409977)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3306/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>