<div dir="ltr"><div class="gmail_default" style="color:#660000">So in all the current channel drivers (that need it), the convention is like such:</div><div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000">
disallow = all</div><div class="gmail_default" style="color:#660000">allow = ulaw, alaw</div><div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000">Which can also be shortened to just:</div>
<div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000">allow = !all, ulaw, alaw</div><div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000">
Which already makes disallow somewhat superfluous.</div><div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000">In PJSIP this has been kept the same way. However, the addition of PJSIP is already a significant change and gives us the opportunity to make a few improvements -- if and where it makes sense to do so. It is also entirely possible to make similar changes to other channel drivers, which can be addressed in the future, but today I'm talking just about PJSIP.</div>
<div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000">The idea of using codecs is that it "reads" better -- tells you what you're allowing or disallowing:</div>
<div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000">codecs = !all, ulaw, alaw</div><div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000">
It's certainly a break with existing convention, however, it makes sense in a way. And we're not talking yet about removing support for allow & disallow, simply adding codecs as the "preferred" method. And if you show endpoint configuration you would see only codecs = !all, ulaw, alaw.</div>
<div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000"><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 6, 2014 at 3:42 PM, Damien Wedhorn <span dir="ltr"><<a href="mailto:voip@facts.com.au" target="_blank">voip@facts.com.au</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u>
<div text="#000000" bgcolor="#ffffff"><div><div class="h5">
On 07/03/14 07:29, Matthew Jordan wrote:
<blockquote type="cite">
<div dir="ltr"><br>
<div class="gmail_extra">On Thu, Mar 6, 2014 at 3:22 PM, Paul
Belanger <span dir="ltr"><<a href="mailto:paul.belanger@polybeacon.com" target="_blank">paul.belanger@polybeacon.com</a>></span>
wrote:<br>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<div>On Thu, Mar 6, 2014 at 3:31 PM, George
Joseph<br>
<<a href="mailto:george.joseph@fairview5.com" target="_blank">george.joseph@fairview5.com</a>>
wrote:<br>
> On Thu, Mar 6, 2014 at 1:22 PM, Scott Griepentrog
<<a href="mailto:sgriepentrog@digium.com" target="_blank">sgriepentrog@digium.com</a>><br>
> wrote:<br>
>><br>
>> First, a smidgen of background:<br>
>><br>
>> The two sorcery options for pjsip.conf
"allow" and "disallow" both accept<br>
>> a list of codecs and set the same table of
codecs in behind the scenes. The<br>
>> difference being of course that the disallow
field inverts the meaning.<br>
>><br>
>> There is some potential confusion here as to
why there is two lists of the<br>
>> exact same codecs (see<br>
>> <a href="https://issues.asterisk.org/jira/browse/ASTERISK-23092" target="_blank">https://issues.asterisk.org/jira/browse/ASTERISK-23092</a>).
I have a suggested<br>
>> patch (see <a href="https://reviewboard.asterisk.org/r/3193/" target="_blank">https://reviewboard.asterisk.org/r/3193/</a>)
to make the disallow<br>
>> option disappear in a fashion. You can still
use the disallow option in<br>
>> pjsip.conf, but when viewing the settings
with pjsip show endpoint # only<br>
>> the allow list would appear. This is
accomplished by marking the disallow<br>
>> field as an alias.<br>
>><br>
>> An option to move away from SIP's convention
of allow/disallow and have<br>
>> PJSIP use codecs=ulaw,etc has been suggested
(and is coded in the review).<br>
>> The question then is:<br>
>><br>
>> 1) Do we want to discontinue or alias both
allow & disallow and move to<br>
>> codecs?<br>
>><br>
>><br>
>> 2) If yes, then which version should that be
done in? 12? 13?<br>
><br>
><br>
> My vote...Move to codecs and alias allow/disallow
in 12, discontinue<br>
> allow/disallow in 13.<br>
><br>
>><br>
>> Note that even if codecs is chosen, allow and
disallow continue to work so<br>
>> no existing pjsip.conf is broken.<br>
>><br>
><br>
</div>
</div>
For me to be on-board with the change, we'd have to apply
it to all<br>
channel drives that implement said codecs allow / disallow
logic, so<br>
sip.conf, chan_ooh323.conf, gtalk.conf, h323.conf,
iax.conf,<br>
jingle.conf.<br>
<br>
That way all our documentation / functionality is
consistent among<br>
channel drivers.<br>
<span></span><br>
</blockquote>
</div>
<br>
</div>
<div class="gmail_extra">Yeah... that will never happen.<br>
</div>
<div class="gmail_extra"><br>
</div>
</div>
</blockquote></div></div>
I assume this is about the codecs option. If so, why couldn't it be
implemented in all the channel drivers. Surely the "codecs list"
option could be a simple wrapper for "disallow all, allow list".<span class="HOEnZb"><font color="#888888"><br>
<br>
Damien Wedhorn<br>
</font></span></div>
<br>--<br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">
<img alt="Digium logo" src="https://my.digium.com/images/graphics/digium_RGB_signature.gif" width="288" height="50" style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px"><div>Scott Griepentrog<br>
Digium, Inc · Software Developer<br>445 Jan Davis Drive NW · Huntsville, AL 35806 · US<br>direct/fax: +1 256 428 6239 · mobile: +1 317 507 4029<br>Check us out at: <a href="http://digium.com" target="_blank">http://digium.com</a> · <a href="http://asterisk.org" target="_blank">http://asterisk.org</a><br>
</div></div>
</div>