<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3268/">https://reviewboard.asterisk.org/r/3268/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>











<p>- Matt Jordan</p>


<br />
<p>On February 25th, 2014, 3:27 p.m. CST, Kevin Harwell wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>


<p style="color: grey;"><i>Updated Feb. 25, 2014, 3:27 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed pre/post checks from any testsuite test that currently contained them.  Fixed a couple of bugs that caused the testsuite to hang (exception thrown causing the twisted reactor to crash) with regards to channel pre/post checks.  Also made it so any future test wishing to utilize this functionality will have its configuration appropriately read.
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran a test using channel pre/post checks.  Changed the number of allowed channels and watched it pass/fail.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>asterisk/trunk/tests/pbx/pbx_lua_goto/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/pbx/pbx_lua_background/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/masquerade/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/funcs/func_srv/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/dynamic-modules/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/channels/pjsip/message/message_send_ami/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/sip_hold_direct_media/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/sip_hold/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/message_send_ami/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/handle_response_address_incomplete/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/callparking/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/play_message/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/leave_voicemail_priority/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding_auto_urgent/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/leave_voicemail_forwarding/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/leave_voicemail_external_notification/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/leave_voicemail_contexts/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/func_vmcount/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_while_leaving_msg/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_reply/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_unavail/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_temp/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_name/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_options_record_busy/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_options_change_password/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_nominal/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user_hangup/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_new_user/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_with_prepend/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_forward_hangup/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_forward/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_envelope/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_dialout/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_delete/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/check_voicemail_callback/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/authenticate_nominal/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/authenticate_invalid_password/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/authenticate_invalid_mailbox/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/voicemail/authenticate_extensions/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/tests/apps/incomplete/sip_incomplete/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/test-config.yaml <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/lib/python/asterisk/test_case.py <span style="color: grey">(4732)</span></li>

 <li>asterisk/trunk/lib/python/asterisk/channel_test_condition.py <span style="color: grey">(4732)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3268/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>