<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3255/">https://reviewboard.asterisk.org/r/3255/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Joshua Colp, Kevin Harwell, and Matt Jordan.</div>
<div>By Jonathan Rose.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2014, 2:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add checks to this patch to make sure that ICE check lists are built successfully on two separate occasions during the call. Fail on ICE check list creation failure.
Test events are added to supply these checks in the following patch:
https://reviewboard.asterisk.org/r/3275/
With those test events added to 11 currently without the rest of the patch, this test will fail because the check list will only be built once.
11.7 will fail this test because the check list will never be built successfully and Asterisk will crash.
My previous patch for ASTERISK-22911 would have failed this test because while the check lists would be built, they would fail on the pruning phase.
With the patch from the above review completely in place, this test is successful.
I'm currently working on a chan_pjsip equivalent to this test.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22911">ASTERISK-22911</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests for a crash occurring in 11.7 when ICE on SIP calls (reproduced from a SIPML5 with 6 total candidate fields in SDP) when holding. The crash is caused by an initially failed ICE session startup followed by a second attempt at doing the startup when a HOLD is received. The crash was resolved in 11.8, but in the process some people lost audio at the start of similar calls that previously worked in 11.7
The test itself is a near duplicate of the existing SIP hold tests, but slightly simplified and with some changes in the call flow. A starts the call and engages hold and unhold. At the conclusion of unhold if all MOH events went through the test will be considered successful.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran test against 11.7. Crashed
Ran test against 11.8. Did not crash.
Ran test against a diagnostic patch I made to check the PJ_NATH errors that were occurring to make sure everything mirrored the results I had been seeing in my reproduction efforts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/SIP/tests.yaml <span style="color: grey">(4726)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_ice/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_ice/sipp/phone_B.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_ice/sipp/phone_A.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_ice/sipp/inject_bridge.csv <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_ice/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_ice/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_ice/configs/ast1/rtp.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_hold_ice/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3255/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>