<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3206/">https://reviewboard.asterisk.org/r/3206/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2014, 12:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed Mark's findings.
Also added tests that check the authentication key field in a HEP packet, as well as IPv6 source/destination addresses. With these tests added, all possible fields now have a corresponding test.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds the following:
* A pluggable module that emulates a HEP capture server for verifying packets.
* A function that can, in a rudimentary fashion, verify SIP packets. It's simplistic, but good enough to verify that Asterisk sent the server the SIP message traffic we sent to it from SIPp.
* A test that verifies that the res_hep/res_hep_pjsip modules forward SIP message traffic to our little capture server.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/tests.yaml <span style="color: grey">(4685)</span></li>
<li>/asterisk/trunk/tests/hep/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip/configs/ast1/hep.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-ipv6/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-ipv6/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-ipv6/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-ipv6/configs/ast1/hep.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-ipv6/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-auth/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-auth/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-auth/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-auth/configs/ast1/hep.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-auth/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/hep_capture_node.py <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3206/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>