<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3191/">https://reviewboard.asterisk.org/r/3191/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Scott Griepentrog.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2014, 11:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New combined phase1 + 2 + revisions from phase1 review</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">channel uniqueid phases 1&2: convert string uniqueid values to structure with time, add ami origination & assignedid</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23120">ASTERISK-23120</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the first and second phase of channel uniqueid changes for ASTERISK-23120, including AMI origination UniqueId parameter to assign id on creation.
* ast_channel_uniqueid structure replaces ast_string values uniqueid and linkedid in channel structure
struct ast_channel_id {
char unique_id[AST_MAX_UNIQUEID]; /*!< Unique Identifier - can be set on originate */
time_t creation_time; /*!< Creation time */
int creation_unique; /*!< sub-second unique value */
}
* ast_channel_linkedid() and ast_channel_uniqueid() return char* as before, referencing only unique_id element
* ast_channel_xxxxxxid_set() are removed, new ast_channel_internal_xxx() functions added to provided needed functions regarding entire ast_channel_id structure
* an issue with argument order to ast_channel_alloc() in chan_mgcp.c was corrected [BUGFIX].
* an issue with argument order to ast_channel_alloc() in chan_gtalk.c was corrected [BUGFIX].
* new parameter const char *assignedid added to chain of functions used to create channels (including all channel drivers xxx_request())
* where channel drivers took struct ast_channel *reqeustor and converted it to linkedid string, these now pass channel as requestor all the way through to ast_channel_alloc so that channel_internal can copy full ast_channel_id linkedid structure with zero penalty.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran new linkedid_check test and received same results. Also ran some bridge tests to check for asserts.
Also ran new Originate with assignedid test: https://reviewboard.asterisk.org/r/3243/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/tests/test_voicemail_api.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/tests/test_substitution.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/tests/test_stasis_endpoints.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/tests/test_stasis_channels.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/tests/test_cel.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/tests/test_cdr.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/tests/test_app.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/res/stasis/control.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/res/res_stasis_snoop.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/res/res_stasis.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/res/res_clioriginate.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/res/res_calendar.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/res/parking/parking_tests.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/res/parking/parking_bridge_features.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/res/parking/parking_applications.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/res/ari/resource_channels.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/res/ari/resource_bridges.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/pbx/pbx_spool.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/pbx.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/message.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/manager.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/dial.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/core_unreal.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/core_local.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/channel_internal_api.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/channel.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/cel.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/ccss.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/bridge_channel.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/bridge_basic.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/main/bridge.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/include/asterisk/pbx.h <span style="color: grey">(408523)</span></li>
<li>/branches/12/include/asterisk/dial.h <span style="color: grey">(408523)</span></li>
<li>/branches/12/include/asterisk/core_unreal.h <span style="color: grey">(408523)</span></li>
<li>/branches/12/include/asterisk/channel_internal.h <span style="color: grey">(408523)</span></li>
<li>/branches/12/include/asterisk/channel.h <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_vpb.cc <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_unistim.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_skinny.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_sip.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_pjsip.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_phone.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_oss.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_nbs.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_multicast_rtp.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_motif.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_misdn.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_mgcp.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_jingle.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_iax2.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_h323.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_gtalk.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_dahdi.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_console.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_bridge_media.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/channels/chan_alsa.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/apps/confbridge/conf_chan_record.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/apps/confbridge/conf_chan_announce.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/apps/app_voicemail.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/apps/app_queue.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/apps/app_page.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/apps/app_originate.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/apps/app_meetme.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/apps/app_followme.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/apps/app_dial.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/apps/app_confbridge.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/apps/app_chanisavail.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/addons/chan_ooh323.c <span style="color: grey">(408523)</span></li>
<li>/branches/12/addons/chan_mobile.c <span style="color: grey">(408523)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3191/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>