<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3234/">https://reviewboard.asterisk.org/r/3234/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 18th, 2014, 10:34 a.m. CST, <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3234/diff/1/?file=53988#file53988line4318" style="color: black; font-weight: bold; text-decoration: underline;">/team/file/apps/app_meetme.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int conf_run(struct ast_channel *chan, struct ast_conference *conf, struct ast_flags64 *confflags, char *optargs[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4318</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span>struct ast_format src;</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4316</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span>conf->transpath[idx] = ast_translator_build_path(ast_channel_rawwriteformat(chan), ast_format_slin);</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4319</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span>struct ast_format dst;</pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4320</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span>ast_format_set(&src, AST_FORMAT_SLINEAR, 0);</pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4321</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span>ast_format_from_old_bitfield(&dst, (1 << idx));</pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4322</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span>conf->transpath[idx] = ast_translator_build_path(&dst, &src);</pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This doesn't seem to be doing the same thing as it used to. It used to set up a translation path from SLIN to 1 << idx. Now it's setting up a translation path from SLIN to the channel's raw write format.
Why is this change being made?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A little earlier in the function, idx is calculated as log2 of the channel's write format original_id (albeit in a more complicated manner), so this code is functionally equivalent.</pre>
<br />
<p>- opticron</p>
<br />
<p>On February 16th, 2014, 9:56 a.m. CST, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2014, 9:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This movies basic channel drivers and applications over to the new media formats API.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/file/media_formats-impl/pbx/pbx_spool.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/main/frame.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/main/format_ng.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/main/format_cap_ng.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/main/format_cap.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/main/format_cache.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/main/format.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/main/codec.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/main/channel_internal_api.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/main/channel.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/translate.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/slin.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/rtp_engine.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/mod_format.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/frame.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/format_ng.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/format_cap_ng.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/format_cap.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/format_cache.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/format.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/data.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/codec.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/include/asterisk/channel.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/codecs/ex_alaw.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/codecs/ex_adpcm.h <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/codecs/codec_adpcm.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/channels/chan_oss.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/channels/chan_bridge_media.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/channels/chan_alsa.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/confbridge/conf_chan_record.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_waitforsilence.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_voicemail.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_test.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_talkdetect.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_speech_utils.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_sms.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_record.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_originate.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_nbscat.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_mp3.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_mixmonitor.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_milliwatt.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_meetme.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_ices.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_festival.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_dumpchan.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_dictate.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_dahdibarge.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_confbridge.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_chanspy.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_amd.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_alarmreceiver.c <span style="color: grey">(408257)</span></li>
<li>/team/file/media_formats-impl/apps/app_agent_pool.c <span style="color: grey">(408257)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3234/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>