<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3228/">https://reviewboard.asterisk.org/r/3228/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm going to go with option (a) on 11+.
(1) If it isn't broken in 1.8, let's not fix it. I have a suspicion that some of the differences here are due to fixes for parallel building of pjproject in 11.
(2) We can still always choose to revert if we can't fix the lastclean dependencies.</pre>
<br />
<p>- Matt Jordan</p>
<br />
<p>On February 15th, 2014, 3:15 a.m. CST, wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Matt Jordan.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2014, 3:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apparently I broke the build with r408084 ( https://reviewboard.asterisk.org/r/3212/ ).
Reproducing:
$ touch .cleancount
$ make
make[1]: Entering directory `.../asterisk-11.x'
make[2]: Entering directory `.../asterisk-11.x'
make[3]: Entering directory `.../asterisk-11.x'
...
<infinite loop here>
$ touch .lastclean
$ make
CC="cc" CXX="" LD="" AR="" RANLIB="" CFLAGS="" LDFLAGS="" make -C menuselect CONFIGURE_SILENT="--silent" makeopts
make[1]: Entering directory `.../asterisk-11.x/menuselect'
make[1]: `makeopts' is up to date.
...
<successful build here>
There is no problem on 1.8, because it lacks these dependencies on .lastclean:
menuselect/menuselect: menuselect/makeopts .lastclean
+$(MAKE_MENUSELECT) menuselect
...
menuselect/makeopts: makeopts .lastclean
+$(MAKE_MENUSELECT) makeopts
Obviously the build should be unbroken.
Three options:
(A) I have a super simple patch here that abuses grep to look for the
MENUSELECT_EMBED= variable here. If you have no grep binary in path,
it gracefully falls back to the previous behaviour.
(B) We could simply revert.
(C) Someone could try to untangle the .lastclean dependencies. But that
should probably be after option (B).
(And for options A and B, should they be from 1.8 and up or 11 and up?)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/Makefile <span style="color: grey">(408192)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3228/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>