<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3178/">https://reviewboard.asterisk.org/r/3178/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2014, 2:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Incorporated all feedback except redness around macro.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change has a few things in it:
1. Some media related things have been moved around to more logical places or their own parts (smoothers).
2. A new implementation of media formats according to https://wiki.asterisk.org/wiki/display/AST/Media+Format+Rewrite. The implementation doesn't completely adhere to the design since I tweaked things but it mostly conforms.
3. Unit tests for the above implementation.
What I'd like feedback on is the actual media formats implementation and the API design itself. Is this something you would be comfortable using?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran unit tests, all passed.
Note: I know AO2 throws a fit and it's because a container isn't getting initialized. Getting said container initialized requires beginning the hacking apart process.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/tests/test_format_cap.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/tests/test_format_cache.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/tests/test_core_format.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/tests/test_core_codec.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/res/res_rtp_asterisk.c <span style="color: grey">(407438)</span></li>
<li>/branches/12/res/res_fax.c <span style="color: grey">(407438)</span></li>
<li>/branches/12/main/smoother.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/frame.c <span style="color: grey">(407438)</span></li>
<li>/branches/12/main/format_ng.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/format_cap_ng.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/format_cache.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/format.c <span style="color: grey">(407438)</span></li>
<li>/branches/12/main/codec_builtin.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/codec.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/main/asterisk.c <span style="color: grey">(407438)</span></li>
<li>/branches/12/include/asterisk/vector.h <span style="color: grey">(407438)</span></li>
<li>/branches/12/include/asterisk/smoother.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/include/asterisk/frame.h <span style="color: grey">(407438)</span></li>
<li>/branches/12/include/asterisk/format_ng.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/include/asterisk/format_cap_ng.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/include/asterisk/format_cache.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/include/asterisk/format.h <span style="color: grey">(407438)</span></li>
<li>/branches/12/include/asterisk/codec.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3178/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>