<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3193/">https://reviewboard.asterisk.org/r/3193/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Scott Griepentrog.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2014, 12:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Completed deprecation flag and added an ifdef'd demonstration of how to use this to migrate configuration options in sorcery.
It's my belief that this option is the best way to easily deal with the allow/disallow confusion - and get a new feature in the process.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23092">ASTERISK-23092</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">WAS:
Insert a ! prefix in the display of endpoint disallow value. Result is:
disallow : !(ulaw|alaw)
NOW:
Remove the disallow option from generated lists, while still accepting it from a configuration file.
This is OPTION 2 - option 1 is https://reviewboard.asterisk.org/r/3136/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran command and checked output.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/res_pjsip_outbound_registration.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/res/res_pjsip_endpoint_identifier_ip.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/res/res_pjsip_acl.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/res/res_pjsip/pjsip_options.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/res/res_pjsip/pjsip_configuration.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/res/res_pjsip/location.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/res/res_pjsip/config_transport.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/res/res_pjsip/config_system.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/res/res_pjsip/config_global.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/res/res_pjsip/config_domain_aliases.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/res/res_pjsip/config_auth.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/main/sorcery.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/main/bucket.c <span style="color: grey">(407566)</span></li>
<li>/branches/12/include/asterisk/sorcery.h <span style="color: grey">(407566)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3193/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>