<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3104/">https://reviewboard.asterisk.org/r/3104/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3104/diff/2/?file=52934#file52934line337" style="color: black; font-weight: bold; text-decoration: underline;">branches/12/res/res_pjsip_endpoint_identifier_ip.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">337</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">RAII_VAR</span><span class="p">(</span><span class="k">struct</span> <span class="n">ast_str</span> <span class="o">*</span><span class="p">,</span> <span class="n">str</span><span class="p">,</span> <span class="n">ast_str_create</span><span class="p">(</span><span class="n">MAX_OBJECT_FIELD</span><span class="p">),</span> <span class="n">ast_free</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This could use a check before usage. ast_str_create isn't on the stack, and could technically fail.</pre>
</div>
<br />
<p>- Matt Jordan</p>
<br />
<p>On January 16th, 2014, 12:04 p.m. CST, George Joseph wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By George Joseph.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2014, 12:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds identify, transport and registration support to the CLI.
Creates 3 additional callbacks, one for an iterator, one for a comparator and one for a container. This eliminates the link dependency from higher level modules to lower level ones.
Eliminates duplicate sorting.
Cleans up output formatting.
Pushes cli registration down to the implementing source file.
Adds several ast_sip_destroy_sorcery functions to complement existing ast_sip_sorcery_initialize functions. The destroy functions unregister cli commands and cli formatters.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/12/res/res_pjsip_outbound_registration.c <span style="color: grey">(405643)</span></li>
<li>branches/12/res/res_pjsip_endpoint_identifier_ip.c <span style="color: grey">(405643)</span></li>
<li>branches/12/res/res_pjsip/pjsip_options.c <span style="color: grey">(405643)</span></li>
<li>branches/12/res/res_pjsip/pjsip_configuration.c <span style="color: grey">(405643)</span></li>
<li>branches/12/res/res_pjsip/pjsip_cli.c <span style="color: grey">(405643)</span></li>
<li>branches/12/res/res_pjsip/location.c <span style="color: grey">(405643)</span></li>
<li>branches/12/res/res_pjsip/include/res_pjsip_private.h <span style="color: grey">(405643)</span></li>
<li>branches/12/res/res_pjsip/config_transport.c <span style="color: grey">(405643)</span></li>
<li>branches/12/res/res_pjsip/config_global.c <span style="color: grey">(405643)</span></li>
<li>branches/12/res/res_pjsip/config_domain_aliases.c <span style="color: grey">(405643)</span></li>
<li>branches/12/res/res_pjsip/config_auth.c <span style="color: grey">(405643)</span></li>
<li>branches/12/include/asterisk/res_pjsip_cli.h <span style="color: grey">(405643)</span></li>
<li>branches/12/include/asterisk/res_pjsip.h <span style="color: grey">(405643)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3104/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>