<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3122/">https://reviewboard.asterisk.org/r/3122/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2014, 8:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23051">ASTERISK-23051</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds back in support for specifying channel variables during an originate without compromising the ability to specify query parameters in the JSON body. This was accomplished by generating the body-parsing code in a separate function instead of being integrated with the URI query parameter parsing code such that it could be called by paths with body parameters. This is transparent to the user of the API and prevents manual duplication of code or data structures.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with a slightly modified originate_with_vars test created for the original functionality by Kevin Harwell.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/12/rest-api/api-docs/channels.json <span style="color: grey">(405252)</span></li>
<li>branches/12/rest-api-templates/res_ari_resource.c.mustache <span style="color: grey">(405252)</span></li>
<li>branches/12/rest-api-templates/param_parsing.mustache <span style="color: grey">(405252)</span></li>
<li>branches/12/rest-api-templates/body_parsing.mustache <span style="color: grey">(PRE-CREATION)</span></li>
<li>branches/12/rest-api-templates/asterisk_processor.py <span style="color: grey">(405252)</span></li>
<li>branches/12/rest-api-templates/ari_resource.h.mustache <span style="color: grey">(405252)</span></li>
<li>branches/12/res/res_ari_sounds.c <span style="color: grey">(405252)</span></li>
<li>branches/12/res/res_ari_playbacks.c <span style="color: grey">(405252)</span></li>
<li>branches/12/res/res_ari_device_states.c <span style="color: grey">(405252)</span></li>
<li>branches/12/res/res_ari_channels.c <span style="color: grey">(405252)</span></li>
<li>branches/12/res/res_ari_bridges.c <span style="color: grey">(405252)</span></li>
<li>branches/12/res/res_ari_asterisk.c <span style="color: grey">(405252)</span></li>
<li>branches/12/res/res_ari_applications.c <span style="color: grey">(405252)</span></li>
<li>branches/12/res/ari/resource_sounds.h <span style="color: grey">(405252)</span></li>
<li>branches/12/res/ari/resource_playbacks.h <span style="color: grey">(405252)</span></li>
<li>branches/12/res/ari/resource_device_states.h <span style="color: grey">(405252)</span></li>
<li>branches/12/res/ari/resource_channels.c <span style="color: grey">(405252)</span></li>
<li>branches/12/res/ari/resource_channels.h <span style="color: grey">(405252)</span></li>
<li>branches/12/res/ari/resource_bridges.h <span style="color: grey">(405252)</span></li>
<li>branches/12/res/ari/resource_asterisk.h <span style="color: grey">(405252)</span></li>
<li>branches/12/res/ari/resource_applications.h <span style="color: grey">(405252)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3122/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>