<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3043/">https://reviewboard.asterisk.org/r/3043/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the latest diff is missing res_pjsip_endpoint_identifier_ip.h and the exports file.</pre>
<br />
<p>- Matt Jordan</p>
<br />
<p>On December 19th, 2013, 9:04 p.m. CST, George Joseph wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By George Joseph.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2013, 9:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22610">ASTERISK-22610</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implements the following cli commands:
pjsip list aors
pjsip list auths
pjsip list channels
pjsip list contacts
pjsip list endpoints
pjsip show aor(s)
pjsip show auth(s)
pjsip show channels
pjsip show endpoint(s)
Also...
Minor modifications made to the AMI command implementations to facilitate reuse.
New function ast_variable_list_sort added to config.c and config.h to implement variable list sorting.
New api ast_sip_for_each_identify added to module res_pjsip_endpoint_identifier_ip. Required new files res_pjsip_endpoint_identifier_ip.h and res_pjsip_endpoint_identifier_ip.exports.in.
Implementation of the summary statistics is still pending.
I'm sure there will be lots of feedback here. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've gone through all the combinations of actions and objects and made sure at least the correct objects are returned, there are no segfaults, errors, etc.
I *think* the formatting is correct but I'll need some feedback.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/12/res/res_pjsip_registrar.c <span style="color: grey">(404396)</span></li>
<li>branches/12/res/res_pjsip_endpoint_identifier_ip.c <span style="color: grey">(404396)</span></li>
<li>branches/12/res/res_pjsip/pjsip_configuration.c <span style="color: grey">(404396)</span></li>
<li>branches/12/res/res_pjsip/pjsip_cli.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>branches/12/res/res_pjsip/location.c <span style="color: grey">(404396)</span></li>
<li>branches/12/res/res_pjsip/include/res_pjsip_private.h <span style="color: grey">(404396)</span></li>
<li>branches/12/res/res_pjsip/config_auth.c <span style="color: grey">(404396)</span></li>
<li>branches/12/main/sorcery.c <span style="color: grey">(404396)</span></li>
<li>branches/12/main/config.c <span style="color: grey">(404396)</span></li>
<li>branches/12/include/asterisk/sorcery.h <span style="color: grey">(404396)</span></li>
<li>branches/12/include/asterisk/res_pjsip_cli.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>branches/12/include/asterisk/res_pjsip.h <span style="color: grey">(404396)</span></li>
<li>branches/12/include/asterisk/config.h <span style="color: grey">(404396)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3043/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>