<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3040/">https://reviewboard.asterisk.org/r/3040/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Mark Michelson and rmudgett.</div>
<div>By Jonathan Rose.</div>
<p style="color: grey;"><i>Updated Dec. 11, 2013, 10:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Richard'd</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There were still a few cases in which ATTENDEDTRANSFER and BLINDTRANSFER wouldn't be set on channels involved with blind and attended transfers. This would happen with features that were initialized by channel driver specific mechanisms in multiparty calls. This patch resolves those cases while attempted to keep the behavior for setting those variables as consistent as possible.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Test One - single peer tansfers
1. Started a two way call between two chan_sip channels.
2. SIP atxfer'd it to an extension that would display the ATTENDEDTRANSFER and BLINDTRANSFER variables
3. repeated test with SIP blindxfer and compared the results.
Without patch:
Blind transfer variable would be present on blind transfer, attended transfer variable would be present on attended transfer.
With patch:
No behavioral change
Test Two - transferring three party calls
1. Started a two way call between two chan_sip channels.
2. Feature ATXfer'd to a local channel that would screech something about weasels every few seconds. Merged into a 3 way call with *3.
3. SIP atxfer'd the bridge to an extension that would display ATTENDEDTRANSFER and BLINDTRANSFER variables
3. repeated test with SIP blindxfer and compared the results.
Without patch:
Attended transfer variables weren't set at all.
Blind transfer variables would be set on the channels that were already in the bridge, but not on the local channel that was used to transfer.
With patch:
Attended transfer variable set for all channels in the bridge as well as the local channel used for the transfer.
Blind transer variables set for all channels in the bridge as well as the local channel used for the transfer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/parking/parking_manager.c <span style="color: grey">(403068)</span></li>
<li>/branches/12/res/parking/parking_bridge_features.c <span style="color: grey">(403068)</span></li>
<li>/branches/12/main/bridge_basic.c <span style="color: grey">(403068)</span></li>
<li>/branches/12/main/bridge.c <span style="color: grey">(403068)</span></li>
<li>/branches/12/include/asterisk/bridge.h <span style="color: grey">(403068)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3040/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>