<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3035/">https://reviewboard.asterisk.org/r/3035/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2013, 2:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed Josh's findings.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The impetus for this function came from looking at the CHANNEL function for chan_sip, and starting to map out what properties should be applied to chan_pjsip.
While I was looking at it, I thought that - other than the name of the endpoint associated with the channel - endpoint details really shouldn't come from the CHANNEL function. They should come from something else. Hence, the PJSIP_ENDPOINT function.
This function lets you query any property configured on an endpoint, for any endpoint, from the dialplan. Assuming the CHANNEL function gets applied to chan_pjsip, this would let you extract information about a channel's endpoint - or whatever endpoint they're going to go talk to.
This has some obvious implications in knowing what's about to happen before you go Dial some endpoint.
As an aside, I think this patch also shows (to a small extent) the usefulness of both Sorcery as well as XML configuration information. More lines of code are spent on sanitizing input than anything else.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testsuite test written and available here:
https://reviewboard.asterisk.org/r/3034/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/main/sorcery.c <span style="color: grey">(403491)</span></li>
<li>/branches/12/funcs/func_pjsip_endpoint.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/doc/snapshots.xslt <span style="color: grey">(403491)</span></li>
<li>/branches/12/doc/appdocsxml.xslt <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/doc/appdocsxml.dtd <span style="color: grey">(403491)</span></li>
<li>/branches/12/Makefile <span style="color: grey">(403491)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3035/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>