<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3038/">https://reviewboard.asterisk.org/r/3038/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 10th, 2013, 6:51 p.m. UTC, <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/3038/diff/2/?file=49287#file49287line650" style="color: black; font-weight: bold; text-decoration: underline;">/branches/12/channels/pjsip/dialplan_functions.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">650</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">func_args</span><span class="o">-></span><span class="n">ret</span> <span class="o">=</span> <span class="n">channel_read_rtp</span><span class="p">(</span><span class="n">func_args</span><span class="o">-></span><span class="n">chan</span><span class="p">,</span> <span class="n">func_args</span><span class="o">-></span><span class="n">type</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">651</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span> <span class="n">func_args</span><span class="o">-></span><span class="n">field</span><span class="p">,</span> <span class="n">func_args</span><span class="o">-></span><span class="n">buf</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">652</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span> <span class="n">func_args</span><span class="o">-></span><span class="n">len</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It may just be reviewboard, but the second and third lines of this are indented waaaaaaay to the right.
I suspect that you used four-space tabs and lined up the arguments just past the opening paren on the preceding line, a la PEP-8 recommendations. However, such practice doesn't work well when dealing with tabs instead of spaces for indention.
This applies to some other function invocations used in this function.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah... I'll just single line these.</pre>
<br />
<p>- Matt</p>
<br />
<p>On December 10th, 2013, 3:51 a.m. UTC, Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2013, 3:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds CHANNEL function support to chan_pjsip. Since things were getting a bit large, all dialplan functions that were in chan_pjsip have also been moved into their own file (dialplan_functions).
Information that can be retrieved:
* rtp,type,[media_type] - Get RTP information, including media source/destination addresses, whether or not the media is secure, etc.
* rtcp,statistic,[media_type] - Get RTCP statistic information
* endpoint - Get the name of the endpoint associated with this channel. Use PJSIP_ENDPOINT to get more info.
* pjsip,type - Get signalling related information, including source/destination addresses, URIs in the INVITE request, whether or not the signalling is using a secure transport, etc.
Note that after this patch is committed, we should go back through the CHANNEL function documentation and move all of the channel technology specific information into <info/> blocks, so that the documentation is co-located with the channel drivers themselves.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See https://reviewboard.asterisk.org/r/3037</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/res_pjsip_t38.c <span style="color: grey">(403470)</span></li>
<li>/branches/12/include/asterisk/res_pjsip_session.h <span style="color: grey">(403470)</span></li>
<li>/branches/12/funcs/func_channel.c <span style="color: grey">(403470)</span></li>
<li>/branches/12/channels/pjsip/include/dialplan_functions.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/channels/pjsip/include/chan_pjsip.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/channels/pjsip/dialplan_functions.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/channels/chan_pjsip.c <span style="color: grey">(403470)</span></li>
<li>/branches/12/channels/Makefile <span style="color: grey">(403470)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3038/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>