<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3021/">https://reviewboard.asterisk.org/r/3021/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Matt Jordan</p>
<br />
<p>On November 20th, 2013, 11:01 p.m. UTC, Jonathan Rose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Matt Jordan, Mark Michelson, and rmudgett.</div>
<div>By Jonathan Rose.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2013, 11:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One test for each of the DIRECTORY_RESULT values except FAILED (since failed isn't actually intended to be possible under normal running conditions... as far as I know)
Uses the app test framework.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran tests, confirmed that each event is issued and that the flow through the dialplan of the main test channel is consistent with each test case and issuing the correct user events.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/apps/tests.yaml <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_operator_exit/test-config.yaml <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_operator_exit/run-test <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_operator_exit/configs/ast2/sip.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_operator_exit/configs/ast2/extensions.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_operator_exit/configs/ast1/sip.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_operator_exit/configs/ast1/extensions.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_context_operator_exit/test-config.yaml <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_context_operator_exit/run-test <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast2/sip.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast2/extensions.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast1/sip.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_context_operator_exit/configs/ast1/extensions.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_attendant_exit/test-config.yaml <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_attendant_exit/run-test <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast2/sip.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast2/extensions.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast1/sip.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory_attendant_exit/configs/ast1/extensions.conf <span style="color: grey">(4344)</span></li>
<li>/asterisk/trunk/tests/apps/directory/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/directory/directory_result/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/directory/directory_result/configs/ast1/users.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/directory/directory_result/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3021/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>