<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3023/">https://reviewboard.asterisk.org/r/3023/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 21st, 2013, 2:17 p.m. UTC, <b>Joshua Colp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The code itself looks fine, the only nagging question I have is why not just treat the variable as a temporary return variable in the case when you have multiple MixMonitor instances and use Set in the dialplan to set another variable to the value. *shrug*</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Two reasons:
1) MixMonitor's invocation is not limited to the dialplan. It has the potential to be started by AMI as well. Therefore, if you had an oddball situation where both a dialplan invocation and an AMI invocation occurred simultaneously, there's a race condition where they each will think that MIXMONITOR_FILENAME is "their" filename.
2) There is precedent in MixMonitor for such an option. The 'i' option allows for you to specify a channel variable into which the MixMonitor's unique ID will be set. Having a similar option for a filename fits the mold pretty well also.</pre>
<br />
<p>- Mark</p>
<br />
<p>On November 20th, 2013, 9:12 p.m. UTC, Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2013, 9:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change introduces an 'f' option for the MixMonitor() application. The argument for this option specifies a channel variable into which the application should store the filename (as in, the full path) instead of the standard MIXMONITOR_FILENAME.
The rationale for this option is that MixMonitor is structured in such a way that a single channel may have multiple simultaneous MixMonitors running at any given time. Thus, the MixMonitor application should not have any assumptions that the channel has only a single MixMonitor being run on it. Setting a single MIXMONITOR_FILENAME channel variable violates such assumptions by overwriting the value set from previous invocations of MixMonitor. By using the 'f' and 'i' options for MixMonitor, a user can easily manage multiple recordings on a single channel.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See https://reviewboard.asterisk.org/r/3024/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_mixmonitor.c <span style="color: grey">(402883)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3023/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>