<div dir="ltr">Just FYI... I've got a whole bunch of pjsip cli stuff waiting on this patch to be committed. Any chance of this happening this week?<div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Fri, Nov 15, 2013 at 12:58 PM, Kevin Harwell <span dir="ltr"><<a href="mailto:reviewboard@asterisk.org" target="_blank">reviewboard@asterisk.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2959/" target="_blank">https://reviewboard.asterisk.org/r/2959/</a>
</td>
</tr>
</tbody></table>
<br>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image:url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>
<p style="color:grey"><i>Updated Nov. 15, 2013, 1:58 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Fixed issues found.</pre>
</td>
</tr>
</tbody></table>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22609" target="_blank">ASTERISK-22609</a>
</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
Asterisk
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Created the following AMI commands and corresponding events for res_pjsip:
PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few select attributes on each.
Events:
EndpointList - for each endpoint a few attributes
EndpointlistComplete - after all endpoints have been listed
PJSIPShowEndpoint - Provides a detail list of attributes for a specified endpoint
Events:
EndpointDetail - attributes on an endpoint
AorDetail - raised for each AOR on an endpoint
AuthDetail - raised for each associated inbound and outbound auth
TransportDetail - transport attributes
IdentifyDetail - attributes for the identify object associated with the endpoint
EndpointDetailComplete - last event raised after all detail events
PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound registrations
Events:
InboundRegistrationDetail - inbound registration attributes for each registration
InboundRegistrationDetailComplete - raised after all detail records have been listed
PJSIPShowRegistrationsOutbound - Provides a detail listing of all outbound registrations
Events:
OutboundRegistrationDetail - outbound registration attributes for each registration
OutboundRegistrationDetailComplete - raised after all detail records have been listed
PJSIPShowSubscriptions - A detail listing of all subscriptions and their attributes
Events:
SubscriptionDetail - on each subscription detailed attributes
SubscriptionDetailComplete - raised after all detail records have been listed</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Ran a few manual tests over AMI and observed the output to make sure things look correct. Also wrote some testsuite tests: <a href="https://reviewboard.asterisk.org/r/2958/" target="_blank">https://reviewboard.asterisk.org/r/2958/</a></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs (updated)</h1>
<ul style="margin-left:3em;padding-left:0">
<li>branches/12/res/res_pjsip_registrar.c <span style="color:grey">(402377)</span></li>
<li>branches/12/res/res_pjsip_pubsub.c <span style="color:grey">(402377)</span></li>
<li>branches/12/res/res_pjsip_outbound_registration.c <span style="color:grey">(402377)</span></li>
<li>branches/12/res/res_pjsip_mwi.c <span style="color:grey">(402377)</span></li>
<li>branches/12/res/res_pjsip_exten_state.c <span style="color:grey">(402377)</span></li>
<li>branches/12/res/res_pjsip_endpoint_identifier_ip.c <span style="color:grey">(402377)</span></li>
<li>branches/12/res/res_pjsip/pjsip_configuration.c <span style="color:grey">(402377)</span></li>
<li>branches/12/res/res_pjsip/location.c <span style="color:grey">(402377)</span></li>
<li>branches/12/res/res_pjsip/include/res_pjsip_private.h <span style="color:grey">(402377)</span></li>
<li>branches/12/res/res_pjsip/config_transport.c <span style="color:grey">(402377)</span></li>
<li>branches/12/res/res_pjsip/config_auth.c <span style="color:grey">(402377)</span></li>
<li>branches/12/res/<a href="http://res_pjsip.exports.in" target="_blank">res_pjsip.exports.in</a> <span style="color:grey">(402377)</span></li>
<li>branches/12/res/res_pjsip.c <span style="color:grey">(402377)</span></li>
<li>branches/12/main/utils.c <span style="color:grey">(402377)</span></li>
<li>branches/12/main/sorcery.c <span style="color:grey">(402377)</span></li>
<li>branches/12/main/acl.c <span style="color:grey">(402377)</span></li>
<li>branches/12/include/asterisk/utils.h <span style="color:grey">(402377)</span></li>
<li>branches/12/include/asterisk/strings.h <span style="color:grey">(402377)</span></li>
<li>branches/12/include/asterisk/sorcery.h <span style="color:grey">(402377)</span></li>
<li>branches/12/include/asterisk/res_pjsip_pubsub.h <span style="color:grey">(402377)</span></li>
<li>branches/12/include/asterisk/res_pjsip.h <span style="color:grey">(402377)</span></li>
<li>branches/12/include/asterisk/acl.h <span style="color:grey">(402377)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2959/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br></div>