<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2994/">https://reviewboard.asterisk.org/r/2994/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Paul Belanger.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2013, 12:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> * s/ast_free_ptr/ast_free/
* Cleaned up ast_http_get_json
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22685">ASTERISK-22685</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch allows ARI to parse request parameters from an incoming JSON
request body, instead of requiring the request to come in as query
parameters (which is just weird for POST and DELETE) or form
parameters (which is okay, but a bit asymmetric given that all of our
responses are JSON).
For any operation that does _not_ have a parameter defined of type
body (i.e. "paramType": "body" in the API declaration), if a request
provides a request body with a Content type of "application/json", the
provided JSON document is parsed and searched for parameters.
The expected fields in the provided JSON document should match the
query parameters defined for the operation. If the parameter has
'allowMultiple' set, then the field in the JSON document may
optionally be an array of values.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testsuite test.
See https://reviewboard.asterisk.org/r/2993/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/tests/test_ari.c <span style="color: grey">(402455)</span></li>
<li>/branches/12/rest-api-templates/swagger_model.py <span style="color: grey">(402455)</span></li>
<li>/branches/12/rest-api-templates/res_ari_resource.c.mustache <span style="color: grey">(402455)</span></li>
<li>/branches/12/rest-api-templates/param_parsing.mustache <span style="color: grey">(402455)</span></li>
<li>/branches/12/rest-api-templates/asterisk_processor.py <span style="color: grey">(402455)</span></li>
<li>/branches/12/res/res_ari_sounds.c <span style="color: grey">(402455)</span></li>
<li>/branches/12/res/res_ari_recordings.c <span style="color: grey">(402455)</span></li>
<li>/branches/12/res/res_ari_playback.c <span style="color: grey">(402455)</span></li>
<li>/branches/12/res/res_ari_endpoints.c <span style="color: grey">(402455)</span></li>
<li>/branches/12/res/res_ari_channels.c <span style="color: grey">(402455)</span></li>
<li>/branches/12/res/res_ari_bridges.c <span style="color: grey">(402455)</span></li>
<li>/branches/12/res/res_ari_asterisk.c <span style="color: grey">(402455)</span></li>
<li>/branches/12/res/res_ari_applications.c <span style="color: grey">(402455)</span></li>
<li>/branches/12/res/res_ari.c <span style="color: grey">(402455)</span></li>
<li>/branches/12/main/http.c <span style="color: grey">(402455)</span></li>
<li>/branches/12/include/asterisk/http.h <span style="color: grey">(402455)</span></li>
<li>/branches/12/include/asterisk/ari.h <span style="color: grey">(402455)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2994/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>