<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2940/">https://reviewboard.asterisk.org/r/2940/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2013, 3:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 402528</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While working on building client libraries from the Swagger API, I
noticed a problem with the nicknames.
channel.deleteChannel()
channel.answerChannel()
channel.muteChannel()
Etc. We put the object name in the nickname (since we were generating C
code), but it makes OO generators redundant.
This patch makes the nicknames more OO friendly. This resulted in a lot
of name changing within the res_ari_*.so modules, but not much else.
There were a couple of other fixed I made in the process.
* When reversible operations (POST /hold, POST /unhold) were made more
RESTful (POST /hold, DELETE /unhold), the path for the second operation
was left in the API declaration. This worked, but really the two
operations should have been on the same API.
* The POST /unmute operation had still not been REST-ified.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hit each ARI resource to ensure it still responded.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/rest-api/api-docs/sounds.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/recordings.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/playback.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/endpoints.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/channels.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/bridges.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/asterisk.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/applications.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/swagger_model.py <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/rest_handler.mustache <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/res_ari_resource.c.mustache <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/asterisk_processor.py <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/ari_resource.h.mustache <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/ari_resource.c.mustache <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_sounds.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_recordings.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_playback.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_events.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_endpoints.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_channels.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_bridges.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_asterisk.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_applications.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_sounds.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_sounds.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_recordings.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_recordings.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_playback.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_playback.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_events.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_events.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_endpoints.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_endpoints.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_channels.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_channels.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_bridges.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_bridges.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_asterisk.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_asterisk.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_applications.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_applications.h <span style="color: grey">(401260)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2940/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>