<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2960/">https://reviewboard.asterisk.org/r/2960/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Matt</p>
<br />
<p>On October 25th, 2013, 1:32 a.m. UTC, rmudgett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2013, 1:32 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/AST-1102">AST-1102</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The system overrides the user muting requests when MOH is playing or a waitmarked user is waiting for a marked user to join. System muting overrides interfere with what the user may wish the muting to be when the system override ends.
* User muting requests are now independent of the system muting overrides. The effective muting is now the logical or of the user request and system override.
* Added a Muted column to the CLI "confbridge list <conference>" command.
* Added a Muted header to the AMI ConfbridgeList action ConfbridgeList event.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested many unmarked/marked/waitmarked user combinations.
While MOH is playing, the effective muting is now always muted.
Before:
A user mute toggle request would immediately change the muting status.
The initial user mute toggle would be different for the only unmarked or marked user in the conference if startmuted is no.
It depended upon if MOH was playing or not.
While a waitmarked user is waiting for a marked user to join, the effective muting is always muted.
Before:
A user mute toggle request would effectively be ignored.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/apps/confbridge/include/confbridge.h <span style="color: grey">(401871)</span></li>
<li>/branches/11/apps/confbridge/conf_state_single_marked.c <span style="color: grey">(401871)</span></li>
<li>/branches/11/apps/confbridge/conf_state_single.c <span style="color: grey">(401871)</span></li>
<li>/branches/11/apps/confbridge/conf_state_multi_marked.c <span style="color: grey">(401871)</span></li>
<li>/branches/11/apps/confbridge/conf_state_multi.c <span style="color: grey">(401871)</span></li>
<li>/branches/11/apps/confbridge/conf_state_inactive.c <span style="color: grey">(401871)</span></li>
<li>/branches/11/apps/confbridge/conf_state.c <span style="color: grey">(401871)</span></li>
<li>/branches/11/apps/app_confbridge.c <span style="color: grey">(401871)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2960/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>