<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2916/">https://reviewboard.asterisk.org/r/2916/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The only real concern I have here is if two DTMF stream operations were queued back to back. When that happens, you have no way to control the pause between the two sets of DTMF. I have seen this type of behavior cause missed digits. Maybe before and after pauses to go along with the between pause time would do the trick. Other than that, this looks good to go.</pre>
<br />
<p>- opticron</p>
<br />
<p>On October 28th, 2013, 2:23 p.m. CDT, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2013, 2:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22701">ASTERISK-22701</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch adds some additional useful functionality:
1. It is now possible to disable explicit answering when doing a playback, which can be used for early media.
2. DTMF can now be posted to a channel which sends the DTMF to it.
3. Indications can now be posted to a channel.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested invoking everything as expected, plus off nominals (missing values, incorrect values).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/rest-api/api-docs/channels.json <span style="color: grey">(402126)</span></li>
<li>/branches/12/res/stasis/control.c <span style="color: grey">(402126)</span></li>
<li>/branches/12/res/res_stasis_playback.c <span style="color: grey">(402126)</span></li>
<li>/branches/12/res/res_ari_channels.c <span style="color: grey">(402126)</span></li>
<li>/branches/12/res/ari/resource_channels.c <span style="color: grey">(402126)</span></li>
<li>/branches/12/res/ari/resource_channels.h <span style="color: grey">(402126)</span></li>
<li>/branches/12/include/asterisk/stasis_app.h <span style="color: grey">(402126)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2916/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>