<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2940/">https://reviewboard.asterisk.org/r/2940/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 28th, 2013, 3:46 p.m. UTC, <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2940/diff/2/?file=47351#file47351line182" style="color: black; font-weight: bold; text-decoration: underline;">/branches/12/rest-api/api-docs/recordings.json</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">182</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"path"</span><span class="p">:</span> <span class="s2">"/recordings/live/{recordingName}/unpause"</span><span class="p">,</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">182</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"path"</span><span class="p">:</span> <span class="s2">"/recordings/live/{recordingName}/unpause"</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">183</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"operations"</span><span class="p">:</span> <span class="p">[</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">183</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"operations"</span><span class="p">:</span> <span class="p">[</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">184</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="p">{</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">184</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">185</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"httpMethod"</span><span class="p">:</span> <span class="s2">"POST"</span><span class="p">,</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">185</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"httpMethod"</span><span class="p">:</span> <span class="s2">"POST"</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">186</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"summary"</span><span class="p">:</span> <span class="s2">"Unpause a live recording."</span><span class="p">,</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">186</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"summary"</span><span class="p">:</span> <span class="s2">"Unpause a live recording."</span><span class="p">,</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">187</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"nickname"</span><span class="p">:</span> <span class="s2">"unpause<span class="hl">Recording</span>"</span><span class="p">,</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">187</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"nickname"</span><span class="p">:</span> <span class="s2">"unpause"</span><span class="p">,</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">188</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"responseClass"</span><span class="p">:</span> <span class="s2">"void"</span><span class="p">,</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">188</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"responseClass"</span><span class="p">:</span> <span class="s2">"void"</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">189</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"parameters"</span><span class="p">:</span> <span class="p">[</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">189</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="nt">"parameters"</span><span class="p">:</span> <span class="p">[</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there any reason that this isn't using DELETE like the other state toggles (hold, MOH, etc.)?</pre>
</blockquote>
<p>On October 29th, 2013, 4:24 p.m. UTC, <b>David Lee</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That was probably missed when we made those changes. It's small enough, I'll include it in this patch.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So the reason we didn't change these before, was we never did decide if a DELETE with parameters was valid. There is still a discussion going on about IIRC.</pre>
<br />
<p>- Paul</p>
<br />
<p>On October 29th, 2013, 7:02 p.m. UTC, David Lee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2013, 7:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While working on building client libraries from the Swagger API, I
noticed a problem with the nicknames.
channel.deleteChannel()
channel.answerChannel()
channel.muteChannel()
Etc. We put the object name in the nickname (since we were generating C
code), but it makes OO generators redundant.
This patch makes the nicknames more OO friendly. This resulted in a lot
of name changing within the res_ari_*.so modules, but not much else.
There were a couple of other fixed I made in the process.
* When reversible operations (POST /hold, POST /unhold) were made more
RESTful (POST /hold, DELETE /unhold), the path for the second operation
was left in the API declaration. This worked, but really the two
operations should have been on the same API.
* The POST /unmute operation had still not been REST-ified.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hit each ARI resource to ensure it still responded.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/rest-api/api-docs/sounds.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/recordings.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/playback.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/endpoints.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/channels.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/bridges.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/asterisk.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api/api-docs/applications.json <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/swagger_model.py <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/rest_handler.mustache <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/res_ari_resource.c.mustache <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/asterisk_processor.py <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/ari_resource.h.mustache <span style="color: grey">(401260)</span></li>
<li>/branches/12/rest-api-templates/ari_resource.c.mustache <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_sounds.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_recordings.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_playback.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_events.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_endpoints.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_channels.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_bridges.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_asterisk.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/res_ari_applications.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_sounds.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_sounds.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_recordings.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_recordings.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_playback.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_playback.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_events.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_events.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_endpoints.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_endpoints.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_channels.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_channels.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_bridges.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_bridges.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_asterisk.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_asterisk.h <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_applications.c <span style="color: grey">(401260)</span></li>
<li>/branches/12/res/ari/resource_applications.h <span style="color: grey">(401260)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2940/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>