<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2939/">https://reviewboard.asterisk.org/r/2939/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, David Lee, Joshua Colp, and kmoore.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2013, 4:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 402001</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22626">ASTERISK-22626</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If a recording is requested against a channel or bridge and an unknown format is used, Asterisk will accept the parameters and return success and then the recording will fail asynchronously. This patch makes Asterisk check the extension to make sure it's actually of a usable type so that we can return failure (422 specifically) before attempting to start the recording.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just the obvious. Used format extension of 'fhqwhgads' and checked to see if it failed before and after the patch. It failed after, would be accepted before. Recordings never succeed of course, I'm just talking the HTTP response.
I've written a test similar to https://reviewboard.asterisk.org/r/2921/ for this, but I'll just let that test sit until that review goes somewhere.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/ari/resource_bridges.c <span style="color: grey">(401105)</span></li>
<li>/branches/12/res/ari/resource_channels.c <span style="color: grey">(401105)</span></li>
<li>/branches/12/res/res_ari_bridges.c <span style="color: grey">(401105)</span></li>
<li>/branches/12/res/res_ari_channels.c <span style="color: grey">(401105)</span></li>
<li>/branches/12/rest-api/api-docs/bridges.json <span style="color: grey">(401105)</span></li>
<li>/branches/12/rest-api/api-docs/channels.json <span style="color: grey">(401105)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2939/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>