<div dir="ltr"><div class="gmail_default" style="color:#660000">I see an advantage to being able to run the entire testsuite with valgrind triggered by a command line option. It makes it easier to do a second pass after a test(s) passes to find out if anything is leaking.</div>
<div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000">However, it is also probable that certain tests are designed specifically to check asterisk under valgrind, so being able to trigger it's use should also be a yaml option.</div>
<div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000">To avoid editing all the test scripts, I would think it easiest to put the mechanism to run valgrind in lib/python/asterisk/asterisk.py in the asterisk.start() function.</div>
<div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000">Possibly use an Asterisk.valgrind = True flag as a trigger for adding valgrind to the cmd arguments,. and then also later on asterisk.stop() the valgrind output file can be checked (assuming to start it with something like --log-file=valgrind.log).</div>
<div class="gmail_default" style="color:#660000"><br></div><div class="gmail_default" style="color:#660000"><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 22, 2013 at 10:36 AM, nitesh bansal <span dir="ltr"><<a href="mailto:nitesh.bansal@gmail.com" target="_blank">nitesh.bansal@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sorry for the incomplete message. Here is the complete message:<div><br></div><div><div class="im"><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">Hi,</span><div style="font-family:arial,sans-serif;font-size:12.727272033691406px">
<br></div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px">I started working on it. Possible options include for running Asterisk under valgrind:</div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px">
1. Pass it as a command line argument: </div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px"> It has the advantage that you don't need to modify your config files depending on whether you want to run Asterisk under valgrind or not. But downside is that you need to modify your test cases</div>
</div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px"> to pass the command line option upstream to TestCase class.</div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px">
<br>
</div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px">2. Define it in a yaml file:</div></div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px"> It has the advantage that existing test scripts need not be modified, but downside is that you need to modify the config file everytime you decide to run Asterisk under valgrind.</div>
<div style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br></div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px">I would prefer the second option, because i don't believe that it is worth to modify all the existing test cases.</div>
<div style="font-family:arial,sans-serif;font-size:12.727272033691406px">Your opinions are welcome.</div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br></div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px">
Regards,</div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px">Nitesh Bansal</div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br></div><div style="font-family:arial,sans-serif;font-size:12.727272033691406px">
</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 22, 2013 at 5:31 PM, nitesh bansal <span dir="ltr"><<a href="mailto:nitesh.bansal@gmail.com" target="_blank">nitesh.bansal@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>I started working on it. Possible options include for running Asterisk under valgrind:</div>
<div>1. Pass it as a command line argument: </div><div> It has the advantage that you don't need to modify your config files depending on whether you want to run Asterisk under valgrind or not. But downside is that you need to modify your test cases</div>
<div><br></div><div>2. Define it in a yaml file</div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Oct 21, 2013 at 10:52 PM, nitesh bansal <span dir="ltr"><<a href="mailto:nitesh.bansal@gmail.com" target="_blank">nitesh.bansal@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yeah,<div><br></div><div>I agree something like that should be sufficient?</div><div><br></div><div>Regards,</div>
<div>Nitesh Bansal</div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Oct 21, 2013 at 10:17 PM, Scott Griepentrog <span dir="ltr"><<a href="mailto:sgriepentrog@digium.com" target="_blank">sgriepentrog@digium.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_default" style="color:rgb(102,0,0)">If it wasn't already there, or somebody doesn't beat me too it, I was planning on doing a simple check of the valgrind output - not to parse it but just to detect it as having reported something amiss and then flag the test as failed (much in the same way that a core dump detection will).</div>
<div class="gmail_default" style="color:rgb(102,0,0)"></div></div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Mon, Oct 21, 2013 at 3:13 PM, nitesh bansal <span dir="ltr"><<a href="mailto:nitesh.bansal@gmail.com" target="_blank">nitesh.bansal@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>I have tracked it down in SVN and i would be happy to continue working on it. Paul, i have a question for you, the time when you had valgrind working for you, were you</div>
<div>
just running asterisk under valgrind or did you write something to parse valgrind output?</div><div><br></div><div>Regards,</div><div>Nitesh Bansal</div></div><div><div><div class="gmail_extra">
<br><br><div class="gmail_quote">
On Mon, Oct 21, 2013 at 8:09 PM, Paul Belanger <span dir="ltr"><<a href="mailto:paul.belanger@polybeacon.com" target="_blank">paul.belanger@polybeacon.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>On <a href="tel:13-10-21%2001" value="+13102101" target="_blank">13-10-21 01</a>:41 PM, Scott Griepentrog wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Sounds like a job for Scott...<br>
<br>
I for one would feel a lot happier running patches through valgrind testing<br>
before posting it up for review.<br>
<br>
I understand the need to keep it as cmd line option though so it's not run<br>
by default.<br>
<br>
</blockquote></div>
At some point in time I actually had the testsuite working with valgrind, but that was a while ago. I know Matt added support for gdb, so I don't imagine it being to hard.<span><font color="#888888"><br>
<br>
-- <br>
Paul Belanger | PolyBeacon, Inc.<br>
Jabber: <a href="mailto:paul.belanger@polybeacon.com" target="_blank">paul.belanger@polybeacon.com</a> | IRC: pabelanger (Freenode)<br>
Github: <a href="https://github.com/pabelanger" target="_blank">https://github.com/pabelanger</a> | Twitter: <a href="https://twitter.com/pabelanger" target="_blank">https://twitter.com/pabelanger</a></font></span><div>
<div><br>
<br>
-- <br>
______________________________<u></u>______________________________<u></u>_________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/<u></u>mailman/listinfo/asterisk-dev</a><br>
</div></div></blockquote></div><br></div>
</div></div><br>--<br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br></blockquote></div><br><br clear="all"><div><br></div></div></div><div>
-- <br><div dir="ltr">
<img alt="Digium logo" width="288" height="50" style="font-size:12px;font-family:Arial,Helvetica,sans-serif"><br style="font-size:12px;font-family:Arial,Helvetica,sans-serif">
<strong style="font-size:12px;font-family:Arial,Helvetica,sans-serif">Scott Griepentrog</strong><br style="font-size:12px;font-family:Arial,Helvetica,sans-serif"><span style="font-size:12px;font-family:Arial,Helvetica,sans-serif">Digium, Inc · Software Developer</span><br style="font-size:12px;font-family:Arial,Helvetica,sans-serif">
<span style="font-size:12px;font-family:Arial,Helvetica,sans-serif">445 Jan Davis Drive NW · Huntsville, AL 35806 · US</span><br style="font-size:12px;font-family:Arial,Helvetica,sans-serif">
<span style="font-size:12px;font-family:Arial,Helvetica,sans-serif">direct/fax: <a href="tel:%2B1%20256%20428%206239" value="+12564286239" target="_blank">+1 256 428 6239</a> · mobile: <a href="tel:%2B1%20317%20507%204029" value="+13175074029" target="_blank">+1 317 507 4029</a></span><br style="font-size:12px;font-family:Arial,Helvetica,sans-serif">
<span style="font-size:12px;font-family:Arial,Helvetica,sans-serif">Check us out at: </span><a href="http://www.digium.com" style="font-family:Arial,Helvetica,sans-serif;font-size:12px" target="_blank">http://digium.com</a><span style="font-size:12px;font-family:Arial,Helvetica,sans-serif"> · </span><a href="http://www.asterisk.org" style="font-family:Arial,Helvetica,sans-serif;font-size:12px" target="_blank">http://asterisk.org</a><br>
</div>
</div></div>
<br>--<br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div><br>--<br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">
<img alt="Digium logo" src="https://my.digium.com/images/graphics/digium_RGB_signature.gif" width="288" height="50" style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px"><br style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px">
<strong style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px">Scott Griepentrog</strong><br style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px"><span style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px">Digium, Inc · Software Developer</span><br style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px">
<span style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px">445 Jan Davis Drive NW · Huntsville, AL 35806 · US</span><br style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px">
<span style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px">direct/fax: +1 256 428 6239 · mobile: +1 317 507 4029</span><br style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px">
<span style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px">Check us out at: </span><a href="http://www.digium.com" style="font-family:Arial,Helvetica,sans-serif;font-size:12px" target="_blank">http://digium.com</a><span style="color:rgb(0,0,0);font-family:Arial,Helvetica,sans-serif;font-size:12px"> · </span><a href="http://www.asterisk.org" style="font-family:Arial,Helvetica,sans-serif;font-size:12px" target="_blank">http://asterisk.org</a><br>
</div>
</div>