<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2941/">https://reviewboard.asterisk.org/r/2941/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and wdoekes.</div>
<div>By Michael Young.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22728">ASTERISK-22728</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Walter Doekes pointed out in ASTERISK-22236, that when running "sip show peers", there can be confusion about what "N" means under the column "Forcerport". The "N" used to stand for NAT (yes). Now, that we use this same column for other settings involving the force_rport setting, someone could get confused as to what is meant by the N.
If "A" is displayed under it, it means auto_force_rport is turned on and force_rport is set to on (yes) for the peer. If "a" (lowercase) is displayed, it means auto_force_rport is turned on but force_rport is off (no) for the peer.
The proposed patch makes a minor change. If force_rport is off, it will use "N" to mean no instead of NAT. If force_rport is on, it will use "Y" to mean yes, the force_rport setting is on for the peer.
This mirrors what is displayed through the manager as well. The manager uses yes and no for these settings.
Also, this patch adds a column for the Comedia setting since that would be helpful to see if auto_force_rport/force_rport AND comedia/auto_comedia are turned on or not.
*** We are not sure whether we should expand the width of the display by adding the Comedia column. So, I am putting this up for review to get feedback on not only on the changes described above but also we would be really interested in everyone's thoughts in regards to adding the ability to see the Comedia setting when "sip show settings" is run.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on local dev box.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/UPGRADE.txt <span style="color: grey">(401181)</span></li>
<li>/branches/11/channels/chan_sip.c <span style="color: grey">(401182)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2941/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>