<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2855/">https://reviewboard.asterisk.org/r/2855/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Corey</p>
<br />
<p>On September 30th, 2013, 2:19 p.m. EDT, jbigelow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By jbigelow.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2013, 2:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">PluggableModules.Originator works fine when a single SIPp scenario and single Originator pluggable module is used for a test. However when more than one of each is used for a test, failures are likely to occur. This is because for each SIPp scenario that starts an origination will occur for every Originator module loaded that is using the scenario_start trigger.
This adds two new optional parameters that may be used in conjunction with a trigger of 'scenario_start'. These help control when an origination occurs, prevent multiple originations from occurring, and correspond a scenario start to a specific scenario. Only one of the parameters may be specified per originator config section.
New parameters:
* scenario-count - Originate only when the specified number of scenario start triggers occur.
* scenario-name - Originate only when the specified scenario is started.
I have updated two tests to use the scenario_start trigger with these new parameters that are included on this review:
* bob_incompatible_codecs - this is updated to use the 'scenario-count' parameter. One SIPp scenario file is used for all the SIPp instances. No origination will occur until all SIPp scenarios have started and each Originator will only originate a single call.
* bob_is_busy - this is updated to use the 'scenario-name' parameter. Multiple copies of the SIPp scenario file were made with each having a unique name to allow the use of this new parameter. For each SIPp scenario that is started only a single origination will occur matching by the scenario file name.
Note: Ignore the 'HangupMonitor' class as my local copy was updated before submitting r2 on this review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Executed the modified tests which all pass.
* For each of the modified tests the logs show that only a single call is originated.
* A call is originated only when the scenario-name matches the SIPp scenario that started for the test using the 'scenario-name' parameter.
* Ensured that without specifying either of the new parameters, the originate works as it did before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/lib/python/asterisk/PluggableModules.py <span style="color: grey">(4239)</span></li>
<li>/asterisk/trunk/sample-yaml/originator-config.yaml.sample <span style="color: grey">(4239)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_incompatible_codecs/test-config.yaml <span style="color: grey">(4239)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/sipp/receive-ipv4-tcp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/sipp/receive-ipv4-udp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/sipp/receive-ipv6-tcp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/sipp/receive-ipv6-udp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/sipp/receive.xml <span style="color: grey">(4239)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/test-config.yaml <span style="color: grey">(4239)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2855/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>