<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2862/">https://reviewboard.asterisk.org/r/2862/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2862/diff/1/?file=46013#file46013line50" style="color: black; font-weight: bold; text-decoration: underline;">/branches/12/include/asterisk/endpoints.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * \return Non-zer on error.</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">s/Non-zer/Non-zero/</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2862/diff/1/?file=46026#file46026line873" style="color: black; font-weight: bold; text-decoration: underline;">/branches/12/res/res_stasis.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">873</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="n">ast_debug</span><span class="p">(</span><span class="mi">1</span><span class="p">,</span> <span class="s">" Channel not found</span><span class="se">\n</span><span class="s">"</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">874</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span class="n">res</span> <span class="o">=</span> <span class="n">STASIS_ASR_EVENT_SOURCE_NOT_FOUND</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Two things:
1) This seems like it should be a warning instead of a debug message, since this will actually prevent the subscription from occurring.
2) This should print the name of the channel that could not be found.
The same goes for the bridge and endpoint cases as well.</pre>
</div>
<br />
<p>- Mark</p>
<br />
<p>On September 17th, 2013, 4:08 p.m. UTC, David Lee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2013, 4:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22451">ASTERISK-22451</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds an /applications API to ARI, allowing explicit management of
Stasis applications.
* GET /applications - list current applications
* GET /applications/{applicationName} - get details of a specific application
* POST /applications/{applicationName}/subscription - explicitly subscribe to
a channel, bridge or endpoint
* DELETE /applications/{applicationName}/subscription - explicitly unsubscribe
from a channel, bridge or endpoint
Subscriptions work by a reference counting mechanism: if you subscript to an
event source X number of times, you must unsubscribe X number of times to stop
receiveing events for that event source.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testsuite tests (https://reviewboard.asterisk.org/r/2863/)
I hit a roadblock testing the endpoint subscription code, so that was tested
manually using wscat and Swagger-UI.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/include/asterisk/endpoints.h <span style="color: grey">(399236)</span></li>
<li>/branches/12/include/asterisk/stasis_app.h <span style="color: grey">(399236)</span></li>
<li>/branches/12/main/asterisk.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/main/endpoints.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/main/json.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/ari.make <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/ari/ari_model_validators.h <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/ari/ari_model_validators.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/ari/resource_applications.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/res/ari/resource_applications.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/res/ari/resource_endpoints.h <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/res_ari_applications.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/res/res_ari_model.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/res_stasis.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/stasis/app.h <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/stasis/app.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/rest-api-templates/ari_model_validators.h.mustache <span style="color: grey">(399236)</span></li>
<li>/branches/12/rest-api/api-docs/applications.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/rest-api/api-docs/endpoints.json <span style="color: grey">(399236)</span></li>
<li>/branches/12/rest-api/api-docs/events.json <span style="color: grey">(399236)</span></li>
<li>/branches/12/rest-api/resources.json <span style="color: grey">(399236)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2862/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>