<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2874/">https://reviewboard.asterisk.org/r/2874/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The pjsip implementation seems a bit odd to me. Rather than setting an interval, why not just set an option similar to sip.conf where a 403 is not treated as a permanent failure? Then, you can add 403 to the list of error responses that sip_outbound_registration_is_temporal treats as a temporary failure. Is there a need to wait a different amount of time than normal for a 403 response as opposed to other responses?</pre>
<br />
<p>- Mark</p>
<br />
<p>On September 23rd, 2013, 7:48 p.m. UTC, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2013, 7:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-17138">ASTERISK-17138</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds an option in chan_sip and chan_pjsip to allow them to continue attempting registration if a 403 is received. Normally, this would cause registration attempts to that endpoint to stop.
In the case of chan_sip, this global option simply allows registration to continue past a 403 as if it was a non-fatal reply to retry later.
For chan_pjsip, this is a per outbound registration option that takes an interval in seconds to wait after a 403 to try again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests are available in the following review:
https://reviewboard.asterisk.org/r/2875/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_sip.c <span style="color: grey">(399644)</span></li>
<li>/trunk/configs/pjsip.conf.sample <span style="color: grey">(399644)</span></li>
<li>/trunk/configs/sip.conf.sample <span style="color: grey">(399644)</span></li>
<li>/trunk/res/res_pjsip_outbound_registration.c <span style="color: grey">(399644)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2874/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>