<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2857/">https://reviewboard.asterisk.org/r/2857/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Without understanding the source code, I just have to say that I really support adding warnings like this, that make it easier to manager and understand Asterisk.</pre>
<br />
<p>- Olle E</p>
<br />
<p>On September 15th, 2013, 3:22 a.m. CEST, Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Sept. 15, 2013, 3:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While tinkering with ConfBridge on an Asterisk setup with a limited set of modules installed, I ran into an error reported from ConfBridge that it couldn't create a bridge due to a failure to create a softmix bridge. Unfortunately, bridge_softmix itself didn't relay why it wasn't created.
Inspecting the code revealed there are three ways creation of a softmix bridge can fail:
1. Memory allocation failure
2. NULL returned from ast_timer_open
3. Thread creation failure
1 and 3 are both unlikely and likely to output an error from their respective routines. Number 2, however, is silent if no timing module is loaded.
This patch adds a warning on that off nominal path.
A lot of folks run Asterisk without a timing source (for whatever reason), which means - since softmix bridges will be used a lot more and in more places in 12 than in the past - a WARNING here is pretty useful.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/bridges/bridge_softmix.c <span style="color: grey">(398805)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2857/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>