<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2845/">https://reviewboard.asterisk.org/r/2845/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2013, 5:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 399136</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22072">ASTERISK-22072</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Dial, Queue, and FollowMe applications need to inhibit the bridging initial connected line exchange in order to support the 'I' option.
* Replaced the pass_reference flag on ast_bridge_join() with a flags parameter to pass other flags defined by enum ast_bridge_join_flags.
* Replaced the independent flag on ast_bridge_impart() with a flags parameter to pass other flags defined by enum ast_bridge_impart_flags.
* Since the Dial, Queue, and FollowMe applications are now the only callers of ast_bridge_call() and ast_bridge_call_with_flags(), changed the calling contract to require the initial COLP exchange to already have been done by the caller.
An independent, but associated change is:
* Reduce stack usage in ast_indicate_data() and add a dropping redundant connected line verbose message.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested Dial, Queue, and FollowMe with and without the 'I' option. The connected line information was as expected.
In the process of testing the Queue I option, I came across a couple of assertions which I filed as ASTERISK-22506 and ASTERISK-22507.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/apps/app_agent_pool.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/apps/confbridge/conf_chan_announce.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/channels/chan_sip.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/include/asterisk/bridge.h <span style="color: grey">(399094)</span></li>
<li>/branches/12/include/asterisk/bridge_channel.h <span style="color: grey">(399094)</span></li>
<li>/branches/12/include/asterisk/features.h <span style="color: grey">(399094)</span></li>
<li>/branches/12/main/bridge.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/main/bridge_basic.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/main/bridge_channel.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/main/channel.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/main/core_local.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/main/core_unreal.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/main/features.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/res/parking/parking_applications.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/res/parking/parking_bridge_features.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/res/parking/parking_tests.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/res/res_pjsip_refer.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/res/stasis/control.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/tests/test_cdr.c <span style="color: grey">(399094)</span></li>
<li>/branches/12/tests/test_cel.c <span style="color: grey">(399094)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2845/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>