<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2854/">https://reviewboard.asterisk.org/r/2854/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers, Joshua Colp and Mark Michelson.</div>
<div>By jrose.</div>








<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-17273">ASTERISK-17273</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test compliments https://reviewboard.asterisk.org/r/2853/

The idea is basically to set up a direct media call between two devices and then have one device send a fresh invite which changes the media to an image to start a T38 session similar to how the transactions went in ASTERISK-17273. The framework for this test is basically recycled from the SIP/sip_hold tests, but it&#39;s stripped down for this purpose.

Without the patch from https://reviewboard.asterisk.org/r/2853/ applied, this test fails because the T.38 reinvite includes only the opposite peer in its SDP contact. With the patch applied, it passes because Asterisk&#39;s address is included as well. Investigation of the logs shows that the opposite peer address is included as well, but for the image portion, a second C=127.0.0.1 IN IPV4 is included as well, so that should solve the situation according to Mark.

WARNING: This test relies on currently dangerous SIPp stuff which needs to be fixed. Similar to sip_hold and originate-cdr-disposition, if this test fails under certain conditions it&#39;s possible for SIPp processes to remain open and confound later tests ran producing failures. A separate patch should probably be made to kill all SIPP processes on startup of a new test at some point.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran the test with and without the patch from https://reviewboard.asterisk.org/r/2853/ and checked how the SIP messages looked compared to what I would expect. This also is a test.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/asterisk/trunk/tests/fax/directmedia_reinvite_t38/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/fax/directmedia_reinvite_t38/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/fax/directmedia_reinvite_t38/run-test <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/fax/directmedia_reinvite_t38/sipp/endpoint_A.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/fax/directmedia_reinvite_t38/sipp/endpoint_B.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/fax/directmedia_reinvite_t38/sipp/inject_bridge.csv <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/fax/directmedia_reinvite_t38/sipp/inject_bypass.csv <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/fax/directmedia_reinvite_t38/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/fax/tests.yaml <span style="color: grey">(4136)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2854/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>