<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>13 sep 2013 kl. 17:08 skrev Joshua Colp <<a href="mailto:jcolp@digium.com">jcolp@digium.com</a>>:</div><br class="Apple-interchange-newline"><blockquote type="cite">Olle E. Johansson wrote:<br><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">- When do you add ;transport ? - When do you use sips: ?<br></blockquote>I assume you mean the code since this can't be set by the user.<br>Transports within pjsip have different properties about them -<br>whether they are secure, whether they are TCP, UDP, TLS, etc. The<br>code above uses these properties to know what to add and when. This<br>code is based on code that already existed within the pjsua library<br>itself.<br><br></blockquote>Right. But you avoided to answer my questions, that are quite<br>important to get right. Can you show some examples?<br></blockquote><br>If the transport is TLS (or otherwise marked as secure) then sips is added. If the transport is not UDP then transport is added.<br></blockquote>If you add sips: you are in a whole other division. You should no do that, it will just cause trouble. It impacts a lot of other headers and is in this case propably a big mistake. Read the RFCs on TLS to get the full picture, RFC 3261 has an update and clarification on the usage. Just assuming that you should use SIPS: in this case will lead to broken communication. SIPS: is not an equivalent of HTTPS:, it's much more and pretty bad.</div><div><br></div><div>If you add a transport you will prevent upgrades from UDP to TCP, which is not a good thing. UDP is always the fallback when someone contacts you, we should encourage if someone prefers to contact us over TLS or TCP to the contact we send.</div><div><br></div><div><blockquote type="cite"><br>This is the above logic in the code you mentioned. I don't know what else you are looking for...<br></blockquote>I just wanted to understand if you where doing this right or wrong, but you confirmed that you did it wrong. Please fix.</div><div><br></div><div>/O<br><blockquote type="cite"><br>-- <br>Joshua Colp<br>Digium, Inc. | Senior Software Developer<br>445 Jan Davis Drive NW - Huntsville, AL 35806 - USA<br>Check us out at: <a href="http://www.digium.com">www.digium.com</a> & <a href="http://www.asterisk.org">www.asterisk.org</a><br><br>--<br>_____________________________________________________________________<br>-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com">http://www.api-digital.com</a> --<br><br>asterisk-dev mailing list<br>To UNSUBSCRIBE or update options visit:<br> <a href="http://lists.digium.com/mailman/listinfo/asterisk-dev">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br></blockquote></div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div>---</div><div>* Olle E Johansson - <a href="mailto:oej@edvina.net">oej@edvina.net</a></div><div>* Cell phone +46 70 593 68 51, Office +46 8 96 40 20, Sweden</div><div><br class="webkit-block-placeholder"></div></span><br class="Apple-interchange-newline">
</div>
<br></body></html>